chrome/browser/password_manager/password_form_manager.cc - Issue 14811010: Add metadata to content::PasswordForm to keep track of the password usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_form_manager.cc

Issue 14811010: Add metadata to content::PasswordForm to keep track of the password usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/login_database.cc ('k') | content/public/common/common_param_traits_macros.h » ('j') | content/public/common/password_form.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_form_manager.cc

diff --git a/chrome/browser/password_manager/password_form_manager.cc b/chrome/browser/password_manager/password_form_manager.cc

index 93a00b0c2d1f3ab421a29fcdd6570c9264ac67af..ba5eb0c34c55333a068563645bf1f62b6bc39752 100644

--- a/chrome/browser/password_manager/password_form_manager.cc

+++ b/chrome/browser/password_manager/password_form_manager.cc

@@ -448,6 +448,9 @@ void PasswordFormManager::UpdateLogin() {

return;

}

+ // Update metadata.

+ pending_credentials_.times_used++;

Ilya Sherman 2013/05/14 07:25:34 nit: Please use the pre-increment operator rather

Garrett Casto 2013/05/14 20:17:58 Done.

UpdatePreferredLoginState(password_store);

// Update the new preferred login.