content/renderer/devtools/devtools_agent.cc - Issue 148083013: Move browser initiated navigation from RenderViewHost to RenderFrameHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/devtools/devtools_agent.cc

Issue 148083013: Move browser initiated navigation from RenderViewHost to RenderFrameHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix ASAN builds. Try 2. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/frame_messages.h ('K') | « content/renderer/accessibility/renderer_accessibility_browsertest.cc ('k') | content/renderer/notification_provider.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/devtools/devtools_agent.cc

diff --git a/content/renderer/devtools/devtools_agent.cc b/content/renderer/devtools/devtools_agent.cc

index a2415441e25a2263e1476a104a1311d5200a1924..62eebbf8c1bbf40dba0036152b2d407e4e16d90e 100644

--- a/content/renderer/devtools/devtools_agent.cc

+++ b/content/renderer/devtools/devtools_agent.cc

@@ -12,6 +12,7 @@

#include "base/process/process.h"

#include "base/strings/string_number_conversions.h"

#include "content/common/devtools_messages.h"

+#include "content/common/frame_messages.h"

#include "content/common/gpu/gpu_messages.h"

#include "content/common/view_messages.h"

#include "content/renderer/devtools/devtools_agent_filter.h"

@@ -105,7 +106,7 @@ bool DevToolsAgent::OnMessageReceived(const IPC::Message& message) {

IPC_MESSAGE_UNHANDLED(handled = false)

IPC_END_MESSAGE_MAP()

- if (message.type() == ViewMsg_Navigate::ID ||

+ if (message.type() == FrameMsg_Navigate::ID ||

message.type() == ViewMsg_Close::ID)

ContinueProgram(); // Don't want to swallow the message.