content/renderer/accessibility/renderer_accessibility_browsertest.cc - Issue 148083013: Move browser initiated navigation from RenderViewHost to RenderFrameHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/renderer_accessibility_browsertest.cc

Issue 148083013: Move browser initiated navigation from RenderViewHost to RenderFrameHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix ASAN builds. Try 2. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/frame_messages.h ('K') | « content/public/test/render_view_test.cc ('k') | content/renderer/devtools/devtools_agent.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/accessibility/renderer_accessibility_browsertest.cc

diff --git a/content/renderer/accessibility/renderer_accessibility_browsertest.cc b/content/renderer/accessibility/renderer_accessibility_browsertest.cc

index ca5d7a199203012c4a1969dbf4ff08f6457c0fc1..03516d9aacafce994a42788d442e82c8e02343b7 100644

--- a/content/renderer/accessibility/renderer_accessibility_browsertest.cc

+++ b/content/renderer/accessibility/renderer_accessibility_browsertest.cc

@@ -3,7 +3,7 @@

// found in the LICENSE file.

#include "base/strings/utf_string_conversions.h"

-#include "content/common/view_messages.h"

+#include "content/common/frame_messages.h"

#include "content/public/test/render_view_test.h"

#include "content/renderer/accessibility/renderer_accessibility_complete.h"

#include "content/renderer/render_view_impl.h"

@@ -354,9 +354,9 @@ TEST_F(RendererAccessibilityTest,

// message that was queued up before will be quickly discarded

// because the element it was referring to no longer exists,

// so the event here is from loading this new page.

- ViewMsg_Navigate_Params nav_params;

+ FrameMsg_Navigate_Params nav_params;

nav_params.url = GURL("data:text/html,<p>Hello, again.</p>");

- nav_params.navigation_type = ViewMsg_Navigate_Type::NORMAL;

+ nav_params.navigation_type = FrameMsg_Navigate_Type::NORMAL;

nav_params.transition = PAGE_TRANSITION_TYPED;

nav_params.current_history_list_length = 1;

nav_params.current_history_list_offset = 0;

« content/common/frame_messages.h ('K') | « content/public/test/render_view_test.cc ('k') | content/renderer/devtools/devtools_agent.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')