Issue 1480723002: [Offline pages] Detecting offline pages missing bookmarks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1480723002: [Offline pages] Detecting offline pages missing bookmarks (Closed)

Created:
5 years ago by fgorski

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Offline pages] Detecting offline pages missing bookmarks This patch refactors logic related to metadata checkup, to include: * offline pages missing archive files * offline pages missing a valid bookmark ID * and handle offline pages marked for deletion if necessary. BUG=

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+145 lines, -38 lines)			Patch
M	chrome/browser/android/offline_pages/offline_page_bridge.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/offline_pages/offline_page_model.h	View	5 chunks	+24 lines, -6 lines	0 comments	Download
M	components/offline_pages/offline_page_model.cc	View	8 chunks	+56 lines, -19 lines	0 comments	Download
M	components/offline_pages/offline_page_model_unittest.cc	View	5 chunks	+64 lines, -12 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

fgorski

4 years, 8 months ago (2016-04-22 15:31:26 UTC) #1

Description was changed from

==========
[Offline pages] Detecting offline pages missing bookmarks

This patch refactors logic related to metadata checkup, to include:
* offline pages missing archive files
* offline pages missing a valid bookmark ID
* and handle offline pages marked for deletion if necessary.

BUG=
==========

to

==========
[Offline pages] Detecting offline pages missing bookmarks

This patch refactors logic related to metadata checkup, to include:
* offline pages missing archive files
* offline pages missing a valid bookmark ID
* and handle offline pages marked for deletion if necessary.

BUG=
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages