[Offline pages] Detecting offline pages missing bookmarks

components/offline_pages/offline_page_model_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/offline_page_model.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
+#include "components/bookmarks/browser/bookmark_model.h"
 #include "components/bookmarks/browser/bookmark_node.h"
+#include "components/bookmarks/test/test_bookmark_client.h"
 #include "components/offline_pages/offline_page_item.h"
 #include "components/offline_pages/offline_page_metadata_store.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
 using SavePageResult = offline_pages::OfflinePageModel::SavePageResult;
 using DeletePageResult = offline_pages::OfflinePageModel::DeletePageResult;
 
 namespace offline_pages {
 
@@ skipping 179 matching lines @@
 
   // OfflinePageMetadataStore callbacks.
   void OnStoreUpdateDone(bool /* success */);
 
   scoped_ptr<OfflinePageTestArchiver> BuildArchiver(
       const GURL& url,
       OfflinePageArchiver::ArchiverResult result);
   scoped_ptr<OfflinePageMetadataStore> BuildStore();
   scoped_ptr<OfflinePageModel> BuildModel(
       scoped_ptr<OfflinePageMetadataStore> store);
-  void ResetModel();
+  void ResetModel(bookmarks::BookmarkModel* bookmarks);
 
   // Utility methods.
   void PumpLoop();
   void ResetResults();
 
   scoped_refptr<base::SingleThreadTaskRunner> task_runner() {
     return message_loop_.task_runner();
   }
 
   OfflinePageModel* model() { return model_.get(); }
@@ skipping 124 matching lines @@
   return scoped_ptr<OfflinePageMetadataStore>(
       new OfflinePageTestStore(task_runner()));
 }
 
 scoped_ptr<OfflinePageModel> OfflinePageModelTest::BuildModel(
     scoped_ptr<OfflinePageMetadataStore> store) {
   return scoped_ptr<OfflinePageModel>(
       new OfflinePageModel(store.Pass(), temp_dir_.path(), task_runner()));
 }
 
-void OfflinePageModelTest::ResetModel() {
+void OfflinePageModelTest::ResetModel(bookmarks::BookmarkModel* bookmarks) {
   model_->RemoveObserver(this);
   OfflinePageTestStore* old_store = GetStore();
   scoped_ptr<OfflinePageMetadataStore> new_store(
       new OfflinePageTestStore(*old_store));
   model_ = BuildModel(new_store.Pass()).Pass();
   model_->AddObserver(this);
+  if (bookmarks)
+    model_->Start(bookmarks);
   PumpLoop();
 }
 
 void OfflinePageModelTest::PumpLoop() {
   base::RunLoop().RunUntilIdle();
 }
 
 void OfflinePageModelTest::ResetResults() {
   last_save_result_ = SavePageResult::CANCELLED;
   last_delete_result_ = DeletePageResult::CANCELLED;
@@ skipping 336 matching lines @@
   // Try to delete this page.
   GetStore()->set_test_scenario(
       OfflinePageTestStore::TestScenario::REMOVE_FAILED);
   model()->DeletePageByBookmarkId(
       kTestPageBookmarkId1, base::Bind(&OfflinePageModelTest::OnDeletePageDone,
                                        AsWeakPtr()));
   PumpLoop();
   EXPECT_EQ(DeletePageResult::STORE_FAILURE, last_delete_result());
 }
 
+// Test for case, where offline copy is missing and it is detected by a
+// metadata check called directly.
 TEST_F(OfflinePageModelTest, DetectThatOfflineCopyIsMissing) {
+  bookmarks::TestBookmarkClient test_bookmark_client;
+  scoped_ptr<bookmarks::BookmarkModel> bookmarks_model(
+      test_bookmark_client.CreateModel());
+  model()->Start(bookmarks_model.get());
+
+  const bookmarks::BookmarkNode* root = bookmarks_model->bookmark_bar_node();
+  const base::string16 title(base::ASCIIToUTF16("foo"));
+  const bookmarks::BookmarkNode* new_node =
+      bookmarks_model->AddURL(root, 0, title, kTestUrl);
+
+  // Save a page.
+  scoped_ptr<OfflinePageTestArchiver> archiver(
+      BuildArchiver(kTestUrl,
+                    OfflinePageArchiver::ArchiverResult::SUCCESSFULLY_CREATED)
+          .Pass());
+  model()->SavePage(
+      kTestUrl, new_node->id(), archiver.Pass(),
+      base::Bind(&OfflinePageModelTest::OnSavePageDone, AsWeakPtr()));
+  PumpLoop();
+
+  ResetResults();
+
+  const OfflinePageItem* page = model()->GetPageByBookmarkId(new_node->id());
+  // Delete the offline copy of the page and check the metadata.
+  base::DeleteFile(page->file_path, false);
+  model()->CheckMetadataConsistency(false);
+  PumpLoop();
+
+  EXPECT_EQ(last_deleted_bookmark_id(), new_node->id());
+  EXPECT_EQ(0UL, model()->GetAllPages().size());
+}
+
+// Test for case, where offline copy is missing and it is detected by a
+// metadata check initiated as part of offline page model load.
+TEST_F(OfflinePageModelTest, DetectThatOfflineCopyIsMissingAfterLoad) {
+  bookmarks::TestBookmarkClient test_bookmark_client;
+  scoped_ptr<bookmarks::BookmarkModel> bookmarks_model(
+      test_bookmark_client.CreateModel());
+  model()->Start(bookmarks_model.get());
+
+  const bookmarks::BookmarkNode* root = bookmarks_model->bookmark_bar_node();
+  const base::string16 title(base::ASCIIToUTF16("foo"));
+  const bookmarks::BookmarkNode* new_node =
+      bookmarks_model->AddURL(root, 0, title, kTestUrl);
+
+  // Save a page.
+  scoped_ptr<OfflinePageTestArchiver> archiver(
+      BuildArchiver(kTestUrl,
+                    OfflinePageArchiver::ArchiverResult::SUCCESSFULLY_CREATED)
+          .Pass());
+  model()->SavePage(
+      kTestUrl, new_node->id(), archiver.Pass(),
+      base::Bind(&OfflinePageModelTest::OnSavePageDone, AsWeakPtr()));
+  PumpLoop();
+
+  ResetResults();
+
+  const OfflinePageItem* page = model()->GetPageByBookmarkId(new_node->id());
+  // Delete the offline copy of the page and check the metadata.
+  base::DeleteFile(page->file_path, false);
+  ResetModel(bookmarks_model.get());
+  // Reseting the model should trigger the metadata consistency check as well.
+  PumpLoop();
+
+  EXPECT_EQ(last_deleted_bookmark_id(), new_node->id());
+  EXPECT_EQ(0UL, model()->GetAllPages().size());
+}
+
+// Test for offline page missing a bookmark in the bookmarks model.
+TEST_F(OfflinePageModelTest, DetectThatBookmarkIsMissingAfterLoad) {
   // Save a page.
   scoped_ptr<OfflinePageTestArchiver> archiver(
       BuildArchiver(kTestUrl,
                     OfflinePageArchiver::ArchiverResult::SUCCESSFULLY_CREATED)
           .Pass());
   model()->SavePage(
       kTestUrl, kTestPageBookmarkId1, archiver.Pass(),
       base::Bind(&OfflinePageModelTest::OnSavePageDone, AsWeakPtr()));
   PumpLoop();
 
   ResetResults();
 
-  const OfflinePageItem* page =
-      model()->GetPageByBookmarkId(kTestPageBookmarkId1);
-  // Delete the offline copy of the page and check the metadata.
-  base::DeleteFile(page->file_path, false);
-  model()->CheckForExternalFileDeletion();
+  // There will be a bookmark model to check against, where the bookmark ID
+  // cannot be found.
+  bookmarks::TestBookmarkClient test_bookmark_client;
+  scoped_ptr<bookmarks::BookmarkModel> bookmarks_model(
+      test_bookmark_client.CreateModel());
+  ResetModel(bookmarks_model.get());
   PumpLoop();
 
   EXPECT_EQ(last_deleted_bookmark_id(), kTestPageBookmarkId1);
-  EXPECT_EQ(0UL, model()->GetAllPages().size());
-}
-
-TEST_F(OfflinePageModelTest, DetectThatOfflineCopyIsMissingAfterLoad) {
-  // Save a page.
-  scoped_ptr<OfflinePageTestArchiver> archiver(
-      BuildArchiver(kTestUrl,
-                    OfflinePageArchiver::ArchiverResult::SUCCESSFULLY_CREATED)
-          .Pass());
-  model()->SavePage(
-      kTestUrl, kTestPageBookmarkId1, archiver.Pass(),
-      base::Bind(&OfflinePageModelTest::OnSavePageDone, AsWeakPtr()));
-  PumpLoop();
-
-  ResetResults();
-
-  const OfflinePageItem* page =
-      model()->GetPageByBookmarkId(kTestPageBookmarkId1);
-  // Delete the offline copy of the page and check the metadata.
-  base::DeleteFile(page->file_path, false);
-  // Reseting the model should trigger the metadata consistency check as well.
-  ResetModel();
-  PumpLoop();
-
-  EXPECT_EQ(last_deleted_bookmark_id(), kTestPageBookmarkId1);
   EXPECT_EQ(0UL, model()->GetAllPages().size());
 }
 
 TEST_F(OfflinePageModelTest, GetPageByBookmarkId) {
   scoped_ptr<OfflinePageTestArchiver> archiver(
       BuildArchiver(kTestUrl,
                     OfflinePageArchiver::ArchiverResult::SUCCESSFULLY_CREATED)
           .Pass());
   model()->SavePage(
       kTestUrl, kTestPageBookmarkId1, archiver.Pass(),
@@ skipping 129 matching lines @@
       BuildArchiver(kTestUrl3,
                     OfflinePageArchiver::ArchiverResult::SUCCESSFULLY_CREATED)
           .Pass());
   model()->SavePage(
       kTestUrl3, kTestPageBookmarkId3, archiver3.Pass(),
       base::Bind(&OfflinePageModelTest::OnSavePageDone, AsWeakPtr()));
   PumpLoop();
   GetStore()->UpdateLastAccessTime(kTestPageBookmarkId3,
                                    now - base::TimeDelta::FromDays(29));
 
-  ResetModel();
+  ResetModel(nullptr);
 
   // Only page_1 and page_2 are expected to be picked up by the model as page_3
   // has not been in the store long enough.
   std::vector<OfflinePageItem> pages_to_clean_up = model()->GetPagesToCleanUp();
   EXPECT_EQ(2UL, pages_to_clean_up.size());
   EXPECT_EQ(kTestUrl, pages_to_clean_up[0].url);
   EXPECT_EQ(kTestPageBookmarkId1, pages_to_clean_up[0].bookmark_id);
   EXPECT_EQ(kTestUrl2, pages_to_clean_up[1].url);
   EXPECT_EQ(kTestPageBookmarkId2, pages_to_clean_up[1].bookmark_id);
 }
@@ skipping 76 matching lines @@
 
   // Chrome should not crash when a bookmark with no offline copy is changed.
   // http://crbug.com/560518
   bookmark_node.set_url(kTestUrl);
   model()->BookmarkNodeChanged(nullptr, &bookmark_node);
   PumpLoop();
   EXPECT_EQ(0UL, model()->GetAllPages().size());
 }
 
 }  // namespace offline_pages