Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1480673004: Revert of [Proxies] Support constructable proxy as new.target (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Proxies] Support constructable proxy as new.target (patchset #3 id:40001 of https://codereview.chromium.org/1481613003/ ) Reason for revert: [Sheriff] Breaks: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/3977 Original issue's description: > [Proxies] Support constructable proxy as new.target > > BUG=v8:1543, v8:3330, v8:3931 > LOG=n > > Committed: https://crrev.com/88ac8aa5236195137d4a7aa18bcc5650a3bdca5a > Cr-Commit-Position: refs/heads/master@{#32346} TBR=ishell@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:1543, v8:3330, v8:3931 Committed: https://crrev.com/87f7dc61faac63fd017b84eb214bae0a34f73514 Cr-Commit-Position: refs/heads/master@{#32350}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -138 lines) Patch
M src/objects.h View 4 chunks +0 lines, -8 lines 0 comments Download
M src/objects.cc View 2 chunks +0 lines, -47 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +12 lines, -42 lines 0 comments Download
D test/mjsunit/es6/classes-proxy.js View 1 chunk +0 lines, -41 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [Proxies] Support constructable proxy as new.target
5 years ago (2015-11-26 16:17:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480673004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480673004/1
5 years ago (2015-11-26 16:20:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 16:20:56 UTC) #4
commit-bot: I haz the power
5 years ago (2015-11-26 16:21:05 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87f7dc61faac63fd017b84eb214bae0a34f73514
Cr-Commit-Position: refs/heads/master@{#32350}

Powered by Google App Engine
This is Rietveld 408576698