Ensure both default audio device IDs are handled for creation.

media/audio/audio_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/environment.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/synchronization/waitable_event.h"
 #include "media/audio/audio_manager.h"
 #include "media/audio/audio_manager_base.h"
+#include "media/audio/audio_output_proxy.h"
 #include "media/audio/audio_unittest_util.h"
 #include "media/audio/fake_audio_log_factory.h"
+#include "media/audio/fake_audio_manager.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 #if defined(USE_ALSA)
 #include "media/audio/alsa/audio_manager_alsa.h"
 #endif  // defined(USE_ALSA)
 
 #if defined(OS_WIN)
 #include "base/win/scoped_com_initializer.h"
 #include "media/audio/win/audio_manager_win.h"
 #include "media/audio/win/wavein_input_win.h"
 #endif
 
 #if defined(USE_PULSEAUDIO)
 #include "media/audio/pulse/audio_manager_pulse.h"
 #endif  // defined(USE_PULSEAUDIO)
 
 namespace media {
 
 // Test fixture which allows us to override the default enumeration API on
 // Windows.
 class AudioManagerTest : public ::testing::Test {
+ public:
+  void HandleDefaultDeviceIDsTest() {
+    AudioParameters params(AudioParameters::AUDIO_PCM_LOW_LATENCY,
+                           CHANNEL_LAYOUT_STEREO, 48000, 16, 2048);
+
+    // Create a stream with the default device id "".
+    AudioOutputStream* stream =
+        audio_manager_->MakeAudioOutputStreamProxy(params, "");
+    ASSERT_TRUE(stream);
+    AudioOutputDispatcher* dispatcher1 =
+        reinterpret_cast<AudioOutputProxy*>(stream)
+            ->get_dispatcher_for_testing();
+
+    // Closing this stream will put it up for reuse.
+    stream->Close();
+    stream = audio_manager_->MakeAudioOutputStreamProxy(
+        params, AudioManagerBase::kDefaultDeviceId);
+
+    // Verify both streams are created with the same dispatcher (which is unique
+    // per device).
+    ASSERT_EQ(dispatcher1, reinterpret_cast<AudioOutputProxy*>(stream)
+                               ->get_dispatcher_for_testing());
+    stream->Close();
+
+    // Create a non-default device and ensure it gets a different dispatcher.
+    stream = audio_manager_->MakeAudioOutputStreamProxy(params, "123456");
+    ASSERT_NE(dispatcher1, reinterpret_cast<AudioOutputProxy*>(stream)
+                               ->get_dispatcher_for_testing());
+    stream->Close();
+  }
+
  protected:
   AudioManagerTest() : audio_manager_(AudioManager::CreateForTesting()) {
     // Wait for audio thread initialization to complete.  Otherwise the
     // enumeration type may not have been set yet.
     base::WaitableEvent event(false, false);
     audio_manager_->GetTaskRunner()->PostTask(FROM_HERE, base::Bind(
         &base::WaitableEvent::Signal, base::Unretained(&event)));
     event.Wait();
   }
 
@@ skipping 98 matching lines @@
                             base::WaitableEvent* event) {
     DCHECK(audio_manager_->GetTaskRunner()->BelongsToCurrentThread());
     closure.Run();
     event->Signal();
   }
 
   FakeAudioLogFactory fake_audio_log_factory_;
   scoped_ptr<AudioManager> audio_manager_;
 };
 
+TEST_F(AudioManagerTest, HandleDefaultDeviceIDs) {
+  // Use a fake manager so we can makeup device ids, this will still use the
+  // AudioManagerBase code.
+  audio_manager_.reset(new FakeAudioManager(&fake_audio_log_factory_));
+  RunOnAudioThread(base::Bind(&AudioManagerTest::HandleDefaultDeviceIDsTest,
+                              base::Unretained(this)));
+}
+
 // Test that devices can be enumerated.
 TEST_F(AudioManagerTest, EnumerateInputDevices) {
   ABORT_AUDIO_TEST_IF_NOT(InputDevicesAvailable());
 
   AudioDeviceNames device_names;
   RunOnAudioThread(
       base::Bind(&AudioManager::GetAudioInputDeviceNames,
                  base::Unretained(audio_manager_.get()),
                  &device_names));
   CheckDeviceNames(device_names);
@@ skipping 196 matching lines @@
       DVLOG(2) << it->unique_id << " matches with " << output_device_id;
       found_an_associated_device = true;
     }
   }
 
   EXPECT_TRUE(found_an_associated_device);
 #endif  // defined(OS_WIN) || defined(OS_MACOSX)
 }
 
 }  // namespace media