third_party/WebKit/LayoutTests/fast/replaced/invalid-object-with-fallback.html - Issue 1480303002: Implement a basic PPAPI plugin for Blink layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/replaced/invalid-object-with-fallback.html

Issue 1480303002: Implement a basic PPAPI plugin for Blink layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Trim comment Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ppapi/tests/blink_test_plugin.cc ('K') | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/platform/linux/plugins/keyboard-events-expected.txt » ('j') | third_party/WebKit/LayoutTests/plugins/mouse-events-fixedpos.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/replaced/invalid-object-with-fallback.html

diff --git a/third_party/WebKit/LayoutTests/fast/replaced/invalid-object-with-fallback.html b/third_party/WebKit/LayoutTests/fast/replaced/invalid-object-with-fallback.html

index b7c3c5cc7f6c331774ac9cad267553fc75dd2ddf..ab1ab1c51c4bc75922e99df532df80f766c2f708 100644

--- a/third_party/WebKit/LayoutTests/fast/replaced/invalid-object-with-fallback.html

+++ b/third_party/WebKit/LayoutTests/fast/replaced/invalid-object-with-fallback.html

@@ -1,8 +1,10 @@

<html>

<head>

- if (window.testRunner)

+ if (window.testRunner) {

testRunner.dumpAsText();

+ testRunner.waitUntilDone();

+ }

function debug(str) {

document.getElementById('console').innerHTML += str + "<br>";

@@ -12,17 +14,15 @@

<body>

<p>This test verifies that an <embed> tag is rendered along with other fallback content when an <object> fails to load. On success, you should see this text, followed by 'PASS'.</p>

- <embed name="plugin" type="application/x-webkit-test-netscape">

+ <embed name="plugin" type="application/x-blink-test-plugin">

</object>

- if (window.internals)

- internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks();

- var plugin = document.plugin;

- if (plugin && plugin.getURL)

- debug("PASS");

- else

- debug("FAIL");

+ document.querySelector("embed").addEventListener("message", function (message) {

dcheng 2015/12/01 01:03:30 Is there a better way to tell if a PPAPI plugin lo

+ debug("PASS");

+ if (window.testRunner)

+ testRunner.notifyDone();

+ });

</script>

</body>

</html>