third_party/WebKit/LayoutTests/fast/replaced/invalid-object-with-fallback.html - Issue 1480303002: Implement a basic PPAPI plugin for Blink layout tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/replaced/invalid-object-with-fallback.html

Issue 1480303002: Implement a basic PPAPI plugin for Blink layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Trim comment Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ppapi/tests/blink_test_plugin.cc ('K') | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/platform/linux/plugins/keyboard-events-expected.txt » ('j') | third_party/WebKit/LayoutTests/plugins/mouse-events-fixedpos.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script>	3 <script>

4 if (window.testRunner)	4 if (window.testRunner) {

5 testRunner.dumpAsText();	5 testRunner.dumpAsText();

	6 testRunner.waitUntilDone();

	7 }

6	8

7 function debug(str) {	9 function debug(str) {

8 document.getElementById('console').innerHTML += str + "<br>";	10 document.getElementById('console').innerHTML += str + "<br>";

9 }	11 }

10 </script>	12 </script>

11 </head>	13 </head>

12 <body>	14 <body>

13 <object>	15 <object>

14 <p>This test verifies that an <embed> tag is rendered along wi th other fallback content when an <object> fails to load. On success, you should see this text, followed by 'PASS'.</p>	16 <p>This test verifies that an <embed> tag is rendered along wi th other fallback content when an <object> fails to load. On success, you should see this text, followed by 'PASS'.</p>

15 <embed name="plugin" type="application/x-webkit-test-netscape">	17 <embed name="plugin" type="application/x-blink-test-plugin">

16 </object>	18 </object>

17 <div id="console"></div>	19 <div id="console"></div>

18 <script>	20 <script>

19 if (window.internals)	21 document.querySelector("embed").addEventListener("message", function (message) {
	dcheng 2015/12/01 01:03:30 Is there a better way to tell if a PPAPI plugin lo Is there a better way to tell if a PPAPI plugin loaded successfully or not? There's a helper function (see below) that somehow guarantees that the closure you pass it will be executed after plugins load, but I don't understand how it works. Without any way to detect if a plugin is actually loaded or not though, I can't use it here.
20 internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTa sks();	22 debug("PASS");

21 var plugin = document.plugin;	23 if (window.testRunner)

22 if (plugin && plugin.getURL)	24 testRunner.notifyDone();

23 debug("PASS");	25 });

24 else

25 debug("FAIL");

26 </script>	26 </script>

27 </body>	27 </body>

28 </html>	28 </html>

OLD	NEW