third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py - Issue 1480303002: Implement a basic PPAPI plugin for Blink layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 1480303002: Implement a basic PPAPI plugin for Blink layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address codereview comment and try to fix Mac Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

index e8b2639b6b93c80961f85559dffc99bad4482bec..7980775f5c80dbb6f494b3e77e180ad3d4d5bf3c 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

@@ -1103,7 +1103,6 @@ class Port(object):

clean_env['DISPLAY'] = self._value_or_default_from_environ('DISPLAY', ':1')

if self.host.platform.is_mac():

clean_env['DYLD_LIBRARY_PATH'] = self._build_path()

- clean_env['DYLD_FRAMEWORK_PATH'] = self._build_path()

variables_to_copy += [

'HOME',

]

« content/renderer/pepper/event_conversion.cc ('K') | « third_party/WebKit/LayoutTests/plugins/webview-plugin-type-change.html ('k') | no next file » | no next file with comments »