content/renderer/pepper/event_conversion.cc - Issue 1480303002: Implement a basic PPAPI plugin for Blink layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/event_conversion.cc

Issue 1480303002: Implement a basic PPAPI plugin for Blink layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address codereview comment and try to fix Mac Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/pepper/event_conversion.cc

diff --git a/content/renderer/pepper/event_conversion.cc b/content/renderer/pepper/event_conversion.cc

index cc658088e65f6e0455ae8c54f496becff2a20dce..34c72c407bd7063bfa31903d5bf0d6744dd89f53 100644

--- a/content/renderer/pepper/event_conversion.cc

+++ b/content/renderer/pepper/event_conversion.cc

@@ -135,14 +135,8 @@ void AppendKeyEvent(const WebInputEvent& event,

InputEventData result = GetEventWithCommonFieldsAndType(event);

result.event_modifiers = key_event.modifiers;

result.key_code = key_event.windowsKeyCode;

-#if defined(OS_MACOSX)

- // Workaround for |domCode| not being set on OS X. crbug.com/493833

dcheng 2015/12/01 23:51:17 I think this should fix the Mac test... hopefully.

- result.code = ui::KeycodeConverter::DomCodeToCodeString(

- ui::KeycodeConverter::NativeKeycodeToDomCode(key_event.nativeKeyCode));

-#else

result.code = ui::KeycodeConverter::DomCodeToCodeString(

static_cast<ui::DomCode>(key_event.domCode));

-#endif

result_events->push_back(result);

}

« no previous file with comments | « content/public/test/ppapi_test_utils.cc ('k') | content/shell/BUILD.gn » ('j') | no next file with comments »