Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 1480303002: Implement a basic PPAPI plugin for Blink layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Mac by removing (hopefully) superfluous DYLD_FRAMEWORK_PATH Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 1085 matching lines...) Expand 10 before | Expand all | Expand 10 after
1096 'XAUTHORITY', 1096 'XAUTHORITY',
1097 'HOME', 1097 'HOME',
1098 'LANG', 1098 'LANG',
1099 'LD_LIBRARY_PATH', 1099 'LD_LIBRARY_PATH',
1100 'DBUS_SESSION_BUS_ADDRESS', 1100 'DBUS_SESSION_BUS_ADDRESS',
1101 'XDG_DATA_DIRS', 1101 'XDG_DATA_DIRS',
1102 ] 1102 ]
1103 clean_env['DISPLAY'] = self._value_or_default_from_environ('DISPLAY' , ':1') 1103 clean_env['DISPLAY'] = self._value_or_default_from_environ('DISPLAY' , ':1')
1104 if self.host.platform.is_mac(): 1104 if self.host.platform.is_mac():
1105 clean_env['DYLD_LIBRARY_PATH'] = self._build_path() 1105 clean_env['DYLD_LIBRARY_PATH'] = self._build_path()
1106 clean_env['DYLD_FRAMEWORK_PATH'] = self._build_path()
dcheng 2015/12/01 22:08:18 This was changed in https://codereview.chromium.or
1107 variables_to_copy += [ 1106 variables_to_copy += [
1108 'HOME', 1107 'HOME',
1109 ] 1108 ]
1110 if self.host.platform.is_win(): 1109 if self.host.platform.is_win():
1111 variables_to_copy += [ 1110 variables_to_copy += [
1112 'PATH', 1111 'PATH',
1113 'GYP_DEFINES', # Required to locate win sdk. 1112 'GYP_DEFINES', # Required to locate win sdk.
1114 ] 1113 ]
1115 if self.host.platform.is_cygwin(): 1114 if self.host.platform.is_cygwin():
1116 variables_to_copy += [ 1115 variables_to_copy += [
(...skipping 677 matching lines...) Expand 10 before | Expand all | Expand 10 after
1794 class PhysicalTestSuite(object): 1793 class PhysicalTestSuite(object):
1795 def __init__(self, base, args, reference_args=None): 1794 def __init__(self, base, args, reference_args=None):
1796 self.name = base 1795 self.name = base
1797 self.base = base 1796 self.base = base
1798 self.args = args 1797 self.args = args
1799 self.reference_args = args if reference_args is None else reference_args 1798 self.reference_args = args if reference_args is None else reference_args
1800 self.tests = set() 1799 self.tests = set()
1801 1800
1802 def __repr__(self): 1801 def __repr__(self):
1803 return "PhysicalTestSuite('%s', '%s', %s, %s)" % (self.name, self.base, self.args, self.reference_args) 1802 return "PhysicalTestSuite('%s', '%s', %s, %s)" % (self.name, self.base, self.args, self.reference_args)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698