Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 22978015: Clean up the way we determine which env vars to pass to content_shell. (Closed)

Created:
7 years, 4 months ago by Dirk Pranke
Modified:
7 years, 4 months ago
Reviewers:
ojan
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Clean up the way we determine which env vars to pass to content_shell. We were passing more variables across than necessary, duplicating some work, and things were generally unclear. This patch consolidates most of the logic and makes things clearer. R=ojan@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156355

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -35 lines) Patch
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 chunk +32 lines, -30 lines 1 comment Download
M Tools/Scripts/webkitpy/layout_tests/port/driver.py View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dirk Pranke
https://codereview.chromium.org/22978015/diff/1/Tools/Scripts/webkitpy/layout_tests/port/base.py File Tools/Scripts/webkitpy/layout_tests/port/base.py (right): https://codereview.chromium.org/22978015/diff/1/Tools/Scripts/webkitpy/layout_tests/port/base.py#newcode877 Tools/Scripts/webkitpy/layout_tests/port/base.py:877: 'WEBKITOUTPUTDIR', # FIXME: Is this still used? Note that ...
7 years, 4 months ago (2013-08-19 21:58:52 UTC) #1
ojan
lgtm
7 years, 4 months ago (2013-08-19 22:09:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/22978015/1
7 years, 4 months ago (2013-08-19 22:10:00 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=2588
7 years, 4 months ago (2013-08-20 01:12:29 UTC) #4
Dirk Pranke
7 years, 4 months ago (2013-08-20 01:28:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r156355 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698