Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: src/x64/code-stubs-x64.cc

Issue 14803005: Erroneous pointer/smi comparison (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Now, in all platforms Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3817 matching lines...) Expand 10 before | Expand all | Expand 10 after
3828 __ j(equal, &done); 3828 __ j(equal, &done);
3829 __ Cmp(rcx, TypeFeedbackCells::MegamorphicSentinel(isolate)); 3829 __ Cmp(rcx, TypeFeedbackCells::MegamorphicSentinel(isolate));
3830 __ j(equal, &done); 3830 __ j(equal, &done);
3831 3831
3832 // Special handling of the Array() function, which caches not only the 3832 // Special handling of the Array() function, which caches not only the
3833 // monomorphic Array function but the initial ElementsKind with special 3833 // monomorphic Array function but the initial ElementsKind with special
3834 // sentinels 3834 // sentinels
3835 Handle<Object> terminal_kind_sentinel = 3835 Handle<Object> terminal_kind_sentinel =
3836 TypeFeedbackCells::MonomorphicArraySentinel(isolate, 3836 TypeFeedbackCells::MonomorphicArraySentinel(isolate,
3837 LAST_FAST_ELEMENTS_KIND); 3837 LAST_FAST_ELEMENTS_KIND);
3838 __ JumpIfNotSmi(rcx, &miss);
3838 __ Cmp(rcx, terminal_kind_sentinel); 3839 __ Cmp(rcx, terminal_kind_sentinel);
3839 __ j(above, &miss); 3840 __ j(above, &miss);
3840 // Make sure the function is the Array() function 3841 // Make sure the function is the Array() function
3841 __ LoadArrayFunction(rcx); 3842 __ LoadArrayFunction(rcx);
3842 __ cmpq(rdi, rcx); 3843 __ cmpq(rdi, rcx);
3843 __ j(not_equal, &megamorphic); 3844 __ j(not_equal, &megamorphic);
3844 __ jmp(&done); 3845 __ jmp(&done);
3845 3846
3846 __ bind(&miss); 3847 __ bind(&miss);
3847 3848
(...skipping 3148 matching lines...) Expand 10 before | Expand all | Expand 10 after
6996 __ jmp(generic_construct_stub, RelocInfo::CODE_TARGET); 6997 __ jmp(generic_construct_stub, RelocInfo::CODE_TARGET);
6997 } 6998 }
6998 } 6999 }
6999 7000
7000 7001
7001 #undef __ 7002 #undef __
7002 7003
7003 } } // namespace v8::internal 7004 } } // namespace v8::internal
7004 7005
7005 #endif // V8_TARGET_ARCH_X64 7006 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698