Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp - Issue 148013008: Use stricter typing for HTMLCollection named getter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp

Issue 148013008: Use stricter typing for HTMLCollection named getter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp

diff --git a/Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp b/Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp

index 24f5fcd3a127ed4380f1f9529b446e55eab5e184..7da3543d9976bbb8d4e5371fc816586c103eb5f3 100644

--- a/Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp

+++ b/Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp

@@ -47,7 +47,7 @@ namespace WebCore {

template<typename CallbackInfo>

static void getNamedItems(HTMLOptionsCollection* collection, const AtomicString& name, const CallbackInfo& info)

{

- Vector<RefPtr<Node> > namedItems;

+ Vector<RefPtr<Element> > namedItems;

collection->namedItems(name, namedItems);

if (!namedItems.size()) {

« no previous file with comments | « Source/bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp ('k') | Source/core/dom/NamedNodesCollection.h » ('j') | no next file with comments »