Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Unified Diff: test/cctest/interpreter/test-bytecode-generator.cc

Issue 1480003002: [runtime] Replace global object link with native context link in all contexts. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add patch from Orion for interpreter cementation test. Disable obsolete/invalid tests. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/compiler/test-js-context-specialization.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/test-bytecode-generator.cc
diff --git a/test/cctest/interpreter/test-bytecode-generator.cc b/test/cctest/interpreter/test-bytecode-generator.cc
index ccddb38b34294ba21625e88028503d479f946ce7..7e8e2a26c19c4110a00268d2638f11fd1ae38d02 100644
--- a/test/cctest/interpreter/test-bytecode-generator.cc
+++ b/test/cctest/interpreter/test-bytecode-generator.cc
@@ -2708,7 +2708,8 @@ TEST(GlobalDelete) {
Zone zone;
int context = Register::function_context().index();
- int global_object_index = Context::GLOBAL_OBJECT_INDEX;
+ int native_context_index = Context::NATIVE_CONTEXT_INDEX;
+ int global_context_index = Context::EXTENSION_INDEX;
FeedbackVectorSpec feedback_spec(&zone);
FeedbackVectorSlot slot = feedback_spec.AddLoadICSlot();
@@ -2720,13 +2721,11 @@ TEST(GlobalDelete) {
1 * kPointerSize,
1,
10,
- {
- B(LdaGlobalSloppy), U8(0), U8(vector->GetIndex(slot)), //
- B(Star), R(0), //
- B(LdaConstant), U8(1), //
- B(DeletePropertySloppy), R(0), //
- B(Return)
- },
+ {B(LdaGlobalSloppy), U8(0), U8(vector->GetIndex(slot)), //
+ B(Star), R(0), //
+ B(LdaConstant), U8(1), //
+ B(DeletePropertySloppy), R(0), //
+ B(Return)},
2,
{InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
@@ -2735,39 +2734,37 @@ TEST(GlobalDelete) {
1 * kPointerSize,
1,
10,
- {
- B(LdaGlobalStrict), U8(0), U8(vector->GetIndex(slot)), //
- B(Star), R(0), //
- B(LdaSmi8), U8(1), //
- B(DeletePropertyStrict), R(0), //
- B(Return)
- },
+ {B(LdaGlobalStrict), U8(0), U8(vector->GetIndex(slot)), //
+ B(Star), R(0), //
+ B(LdaSmi8), U8(1), //
+ B(DeletePropertyStrict), R(0), //
+ B(Return)},
1,
{InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
{"var a = {x:13, y:14};\n function f() { return delete a; };\n f();",
- 1 * kPointerSize,
+ 2 * kPointerSize,
1,
- 10,
- {
- B(LdaContextSlot), R(context), U8(global_object_index), //
- B(Star), R(0), //
- B(LdaConstant), U8(0), //
- B(DeletePropertySloppy), R(0), //
- B(Return)
- },
+ 15,
+ {B(LdaContextSlot), R(context), U8(native_context_index), //
+ B(Star), R(0), //
+ B(LdaContextSlot), R(0), U8(global_context_index), //
+ B(Star), R(1), //
+ B(LdaConstant), U8(0), //
+ B(DeletePropertySloppy), R(1), //
+ B(Return)},
1,
{InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
{"b = 30;\n function f() { return delete b; };\n f();",
- 1 * kPointerSize,
+ 2 * kPointerSize,
1,
- 10,
- {
- B(LdaContextSlot), R(context), U8(global_object_index), //
- B(Star), R(0), //
- B(LdaConstant), U8(0), //
- B(DeletePropertySloppy), R(0), //
- B(Return)
- },
+ 15,
+ {B(LdaContextSlot), R(context), U8(native_context_index), //
+ B(Star), R(0), //
+ B(LdaContextSlot), R(0), U8(global_context_index), //
+ B(Star), R(1), //
+ B(LdaConstant), U8(0), //
+ B(DeletePropertySloppy), R(1), //
+ B(Return)},
1,
{InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}}};
« no previous file with comments | « test/cctest/compiler/test-js-context-specialization.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698