Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1229)

Unified Diff: third_party/WebKit/Source/modules/app_banner/AppBannerController.cpp

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add
Patch Set: Fix typo Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/app_banner/AppBannerController.cpp
diff --git a/third_party/WebKit/Source/modules/app_banner/AppBannerController.cpp b/third_party/WebKit/Source/modules/app_banner/AppBannerController.cpp
index e1cc325f45a896bd8abce63c84d6cf9affdc0bfe..88262955b222a01eb94ec054ccb79102cb212963 100644
--- a/third_party/WebKit/Source/modules/app_banner/AppBannerController.cpp
+++ b/third_party/WebKit/Source/modules/app_banner/AppBannerController.cpp
@@ -27,8 +27,9 @@ void AppBannerController::willShowInstallBannerPrompt(int requestId, WebAppBanne
// dispatchEvent() returns whether the default behavior can happen. In other
// words, it returns false if preventDefault() was called.
- *reply = frame->domWindow()->dispatchEvent(BeforeInstallPromptEvent::create(EventTypeNames::beforeinstallprompt, frame->document(), wtfPlatforms, requestId, client))
- ? WebAppBannerPromptReply::None : WebAppBannerPromptReply::Cancel;
+ *reply = frame->domWindow()->dispatchEvent(BeforeInstallPromptEvent::create(EventTypeNames::beforeinstallprompt, frame->document(), wtfPlatforms, requestId, client)) == DispatchEventResult::NotCanceled
+ ? WebAppBannerPromptReply::None
+ : WebAppBannerPromptReply::Cancel;
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698