Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Side by Side Diff: third_party/WebKit/Source/modules/app_banner/AppBannerController.cpp

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add
Patch Set: Fix typo Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/app_banner/AppBannerController.h" 5 #include "modules/app_banner/AppBannerController.h"
6 6
7 #include "core/EventTypeNames.h" 7 #include "core/EventTypeNames.h"
8 #include "core/dom/Document.h" 8 #include "core/dom/Document.h"
9 #include "core/frame/DOMWindow.h" 9 #include "core/frame/DOMWindow.h"
10 #include "core/frame/LocalFrame.h" 10 #include "core/frame/LocalFrame.h"
11 #include "modules/app_banner/BeforeInstallPromptEvent.h" 11 #include "modules/app_banner/BeforeInstallPromptEvent.h"
12 #include "platform/RuntimeEnabledFeatures.h" 12 #include "platform/RuntimeEnabledFeatures.h"
13 #include "public/platform/WebVector.h" 13 #include "public/platform/WebVector.h"
14 #include "public/platform/modules/app_banner/WebAppBannerClient.h" 14 #include "public/platform/modules/app_banner/WebAppBannerClient.h"
15 #include "public/platform/modules/app_banner/WebAppBannerPromptReply.h" 15 #include "public/platform/modules/app_banner/WebAppBannerPromptReply.h"
16 16
17 namespace blink { 17 namespace blink {
18 18
19 // static 19 // static
20 void AppBannerController::willShowInstallBannerPrompt(int requestId, WebAppBanne rClient* client, LocalFrame* frame, const WebVector<WebString>& platforms, WebAp pBannerPromptReply* reply) 20 void AppBannerController::willShowInstallBannerPrompt(int requestId, WebAppBanne rClient* client, LocalFrame* frame, const WebVector<WebString>& platforms, WebAp pBannerPromptReply* reply)
21 { 21 {
22 ASSERT(RuntimeEnabledFeatures::appBannerEnabled()); 22 ASSERT(RuntimeEnabledFeatures::appBannerEnabled());
23 23
24 Vector<String> wtfPlatforms; 24 Vector<String> wtfPlatforms;
25 for (const WebString& platform : platforms) 25 for (const WebString& platform : platforms)
26 wtfPlatforms.append(platform); 26 wtfPlatforms.append(platform);
27 27
28 // dispatchEvent() returns whether the default behavior can happen. In other 28 // dispatchEvent() returns whether the default behavior can happen. In other
29 // words, it returns false if preventDefault() was called. 29 // words, it returns false if preventDefault() was called.
30 *reply = frame->domWindow()->dispatchEvent(BeforeInstallPromptEvent::create( EventTypeNames::beforeinstallprompt, frame->document(), wtfPlatforms, requestId, client)) 30 *reply = frame->domWindow()->dispatchEvent(BeforeInstallPromptEvent::create( EventTypeNames::beforeinstallprompt, frame->document(), wtfPlatforms, requestId, client)) == DispatchEventResult::NotCanceled
31 ? WebAppBannerPromptReply::None : WebAppBannerPromptReply::Cancel; 31 ? WebAppBannerPromptReply::None
32 : WebAppBannerPromptReply::Cancel;
32 } 33 }
33 34
34 } // namespace blink 35 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698