Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: third_party/WebKit/Source/core/input/PointerEventManager.cpp

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add
Patch Set: Fix comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/PointerEventManager.cpp
diff --git a/third_party/WebKit/Source/core/input/PointerEventManager.cpp b/third_party/WebKit/Source/core/input/PointerEventManager.cpp
index 49c45d674e804db10304f03008adf5eab5008230..5a2c7a77d2fe2dc3f3bed13f597a259dba4d3c69 100644
--- a/third_party/WebKit/Source/core/input/PointerEventManager.cpp
+++ b/third_party/WebKit/Source/core/input/PointerEventManager.cpp
@@ -67,8 +67,8 @@ WebInputEventResult dispatchPointerEvent(
if (!RuntimeEnabledFeatures::pointerEventEnabled())
return WebInputEventResult::NotHandled;
if (!checkForListener || target->hasEventListeners(pointerEvent->type())) {
- bool dispatchResult = target->dispatchEvent(pointerEvent);
- return EventHandler::eventToEventResult(pointerEvent, dispatchResult);
+ DispatchEventResult dispatchResult = target->dispatchEvent(pointerEvent);
philipj_slow 2016/02/25 15:23:46 Like this :)
dtapuska 2016/02/25 22:06:10 Acknowledged.
+ return EventHandler::toWebInputEventResult(dispatchResult);
}
return WebInputEventResult::NotHandled;
}
@@ -89,8 +89,8 @@ WebInputEventResult dispatchMouseEvent(
RefPtrWillBeRawPtr<MouseEvent> event = MouseEvent::create(mouseEventType,
targetNode->document().domWindow(), mouseEvent, detail,
relatedTarget ? relatedTarget->toNode() : nullptr);
- bool res = target->dispatchEvent(event);
- return EventHandler::eventToEventResult(event, res);
+ DispatchEventResult res = target->dispatchEvent(event);
+ return EventHandler::toWebInputEventResult(res);
}
return WebInputEventResult::NotHandled;
}

Powered by Google App Engine
This is Rietveld 408576698