third_party/WebKit/Source/core/page/ContextMenuController.cpp - Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/ContextMenuController.cpp

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add

Patch Set: Fix comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/input/PointerEventManager.cpp ('K') | « third_party/WebKit/Source/core/input/PointerEventManager.cpp ('k') | third_party/WebKit/Source/core/page/DragController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/ContextMenuController.cpp

diff --git a/third_party/WebKit/Source/core/page/ContextMenuController.cpp b/third_party/WebKit/Source/core/page/ContextMenuController.cpp

index 515a3e18c942d861d8dcb83dd00d236a05e8ae49..5697ccf23cdbd1abc0ab18a1e5099eb5bff2d372 100644

--- a/third_party/WebKit/Source/core/page/ContextMenuController.cpp

+++ b/third_party/WebKit/Source/core/page/ContextMenuController.cpp

@@ -98,7 +98,7 @@ void ContextMenuController::populateCustomContextMenu(const Event& event)

if (!menuElement || !equalIgnoringCase(menuElement->fastGetAttribute(typeAttr), "context"))

return;

RefPtrWillBeRawPtr<RelatedEvent> relatedEvent = RelatedEvent::create(EventTypeNames::show, true, true, node);

- if (!menuElement->dispatchEvent(relatedEvent.release()))

+ if (menuElement->dispatchEvent(relatedEvent.release()) != DispatchEventResult::NotCanceled)

return;

if (menuElement != element.assignedContextMenu())

return;