third_party/WebKit/Source/core/input/EventHandler.h - Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.h

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add

Patch Set: Add back the EventDispatchResult enum Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/events/MouseEvent.cpp ('K') | « third_party/WebKit/Source/core/html/track/TextTrackCue.cpp ('k') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('j') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/input/EventHandler.h

diff --git a/third_party/WebKit/Source/core/input/EventHandler.h b/third_party/WebKit/Source/core/input/EventHandler.h

index 0674625268707e3dcfe469af9634a3b4d7956b3e..5ca420e1a53a542116e92ec6a55b481e6ee79007 100644

--- a/third_party/WebKit/Source/core/input/EventHandler.h

+++ b/third_party/WebKit/Source/core/input/EventHandler.h

@@ -179,7 +179,7 @@ public:

void setMouseDownMayStartAutoscroll() { m_mouseDownMayStartAutoscroll = true; }

static WebInputEventResult mergeEventResult(WebInputEventResult resultA, WebInputEventResult resultB);

- static WebInputEventResult eventToEventResult(PassRefPtrWillBeRawPtr<Event>, bool);

+ static WebInputEventResult eventDispatchResultToWebInputEventResult(EventTarget::DispatchEventResult);

tkent 2016/02/22 01:40:22 nit: In the current convention, this function can

dtapuska 2016/02/23 19:14:40 Done.

static PlatformEvent::Modifiers accessKeyModifiers();

bool handleAccessKey(const PlatformKeyboardEvent&);