Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: third_party/WebKit/Source/core/input/EventHandler.h

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add
Patch Set: Add back the EventDispatchResult enum Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 // FIXME: This doesn't appear to be used outside tests anymore, what path ar e we using now and is it tested? 172 // FIXME: This doesn't appear to be used outside tests anymore, what path ar e we using now and is it tested?
173 bool bestZoomableAreaForTouchPoint(const IntPoint& touchCenter, const IntSiz e& touchRadius, IntRect& targetArea, Node*& targetNode); 173 bool bestZoomableAreaForTouchPoint(const IntPoint& touchCenter, const IntSiz e& touchRadius, IntRect& targetArea, Node*& targetNode);
174 174
175 WebInputEventResult sendContextMenuEvent(const PlatformMouseEvent&, Node* ov errideTargetNode = nullptr); 175 WebInputEventResult sendContextMenuEvent(const PlatformMouseEvent&, Node* ov errideTargetNode = nullptr);
176 WebInputEventResult sendContextMenuEventForKey(Element* overrideTargetElemen t = nullptr); 176 WebInputEventResult sendContextMenuEventForKey(Element* overrideTargetElemen t = nullptr);
177 WebInputEventResult sendContextMenuEventForGesture(const GestureEventWithHit TestResults&); 177 WebInputEventResult sendContextMenuEventForGesture(const GestureEventWithHit TestResults&);
178 178
179 void setMouseDownMayStartAutoscroll() { m_mouseDownMayStartAutoscroll = true ; } 179 void setMouseDownMayStartAutoscroll() { m_mouseDownMayStartAutoscroll = true ; }
180 180
181 static WebInputEventResult mergeEventResult(WebInputEventResult resultA, Web InputEventResult resultB); 181 static WebInputEventResult mergeEventResult(WebInputEventResult resultA, Web InputEventResult resultB);
182 static WebInputEventResult eventToEventResult(PassRefPtrWillBeRawPtr<Event>, bool); 182 static WebInputEventResult eventDispatchResultToWebInputEventResult(EventTar get::DispatchEventResult);
tkent 2016/02/22 01:40:22 nit: In the current convention, this function can
dtapuska 2016/02/23 19:14:40 Done.
183 183
184 static PlatformEvent::Modifiers accessKeyModifiers(); 184 static PlatformEvent::Modifiers accessKeyModifiers();
185 bool handleAccessKey(const PlatformKeyboardEvent&); 185 bool handleAccessKey(const PlatformKeyboardEvent&);
186 WebInputEventResult keyEvent(const PlatformKeyboardEvent&); 186 WebInputEventResult keyEvent(const PlatformKeyboardEvent&);
187 void defaultKeyboardEventHandler(KeyboardEvent*); 187 void defaultKeyboardEventHandler(KeyboardEvent*);
188 188
189 bool handleTextInputEvent(const String& text, Event* underlyingEvent = nullp tr, TextEventInputType = TextEventInputKeyboard); 189 bool handleTextInputEvent(const String& text, Event* underlyingEvent = nullp tr, TextEventInputType = TextEventInputKeyboard);
190 void defaultTextInputEventHandler(TextEvent*); 190 void defaultTextInputEventHandler(TextEvent*);
191 191
192 void dragSourceEndedAt(const PlatformMouseEvent&, DragOperation); 192 void dragSourceEndedAt(const PlatformMouseEvent&, DragOperation);
(...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after
456 // scroll which shouldn't propagate can't cause any element to 456 // scroll which shouldn't propagate can't cause any element to
457 // scroll other than the |m_previousGestureScrolledNode|. 457 // scroll other than the |m_previousGestureScrolledNode|.
458 bool m_deltaConsumedForScrollSequence; 458 bool m_deltaConsumedForScrollSequence;
459 }; 459 };
460 460
461 } // namespace blink 461 } // namespace blink
462 462
463 WTF_ALLOW_INIT_WITH_MEM_FUNCTIONS(blink::EventHandler::TouchInfo); 463 WTF_ALLOW_INIT_WITH_MEM_FUNCTIONS(blink::EventHandler::TouchInfo);
464 464
465 #endif // EventHandler_h 465 #endif // EventHandler_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698