third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp - Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add

Patch Set: Add back the EventDispatchResult enum Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/events/MouseEvent.cpp ('K') | « third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp ('k') | third_party/WebKit/Source/core/html/HTMLFormElement.cpp » ('j') | third_party/WebKit/Source/core/input/EventHandler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp b/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

index 06c7f3153e7485af8302066a1d9a3e7c590a8d2d..0a4814bf7adc6d5ae9df9b287cf7f64e7c6106b1 100644

--- a/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

@@ -539,8 +539,8 @@ bool HTMLFormControlElement::checkValidity(WillBeHeapVector<RefPtrWillBeMember<H

// An event handler can deref this object.

RefPtrWillBeRawPtr<HTMLFormControlElement> protector(this);

RefPtrWillBeRawPtr<Document> originalDocument(document());

- bool needsDefaultAction = dispatchEvent(Event::createCancelable(EventTypeNames::invalid));

- if (needsDefaultAction && unhandledInvalidControls && inDocument() && originalDocument == document())

+ EventTarget::DispatchEventResult eventResult = dispatchEvent(Event::createCancelable(EventTypeNames::invalid));

+ if (eventResult == EventTarget::DispatchEventResult::NotHandled && unhandledInvalidControls && inDocument() && originalDocument == document())

unhandledInvalidControls->append(this);

return false;

}