Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 147983009: Mojo: Refactor some message pipe stuff. (Closed)

Created:
6 years, 10 months ago by viettrungluu
Modified:
6 years, 10 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Refactor some message pipe stuff. Move handling of dispatchers when enqueueing messages into the endpoint code. That handling will need to be very specific to the type of endpoint. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247753

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -127 lines) Patch
M mojo/system/local_message_pipe_endpoint.h View 3 chunks +21 lines, -8 lines 0 comments Download
M mojo/system/local_message_pipe_endpoint.cc View 4 chunks +45 lines, -31 lines 0 comments Download
M mojo/system/message_pipe.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/message_pipe.cc View 2 chunks +2 lines, -21 lines 0 comments Download
M mojo/system/message_pipe_endpoint.h View 1 chunk +4 lines, -13 lines 0 comments Download
M mojo/system/proxy_message_pipe_endpoint.h View 2 chunks +8 lines, -5 lines 0 comments Download
M mojo/system/proxy_message_pipe_endpoint.cc View 2 chunks +50 lines, -48 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
6 years, 10 months ago (2014-01-29 20:33:56 UTC) #1
darin (slow to review)
LGTM
6 years, 10 months ago (2014-01-29 20:43:44 UTC) #2
viettrungluu
6 years, 10 months ago (2014-01-29 22:20:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r247753 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698