Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: mojo/system/message_pipe_endpoint.h

Issue 147983009: Mojo: Refactor some message pipe stuff. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/system/message_pipe.cc ('k') | mojo/system/proxy_message_pipe_endpoint.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/system/message_pipe_endpoint.h
diff --git a/mojo/system/message_pipe_endpoint.h b/mojo/system/message_pipe_endpoint.h
index 835b96670789781625913dc1ad3cb3e0e776927c..4825b37160c2c686bdd440e21fe0416b3caa1998 100644
--- a/mojo/system/message_pipe_endpoint.h
+++ b/mojo/system/message_pipe_endpoint.h
@@ -37,20 +37,11 @@ class MOJO_SYSTEM_IMPL_EXPORT MessagePipeEndpoint {
// All implementations must implement these.
virtual void Close() = 0;
virtual void OnPeerClose() = 0;
- // Checks if |EnqueueMessage()| will be able to enqueue the given message
- // (with the given set of dispatchers). |dispatchers| should be non-null only
- // if it's nonempty. Returns |MOJO_RESULT_OK| if it will and an appropriate
- // error code if it won't.
- virtual MojoResult CanEnqueueMessage(
- const MessageInTransit* message,
- const std::vector<Dispatcher*>* dispatchers) = 0;
- // Takes ownership of |message| and the contents of |dispatchers| (leaving
- // it empty). This should only be called after |CanEnqueueMessage()| has
- // indicated success. (Unlike |CanEnqueueMessage()|, |dispatchers| may be
- // non-null but empty.)
- virtual void EnqueueMessage(
+ // Implements |MessagePipe::EnqueueMessage()| (see its description for
+ // details).
+ virtual MojoResult EnqueueMessage(
MessageInTransit* message,
- std::vector<scoped_refptr<Dispatcher> >* dispatchers) = 0;
+ const std::vector<Dispatcher*>* dispatchers) = 0;
// Implementations must override these if they represent a local endpoint,
// i.e., one for which there's a |MessagePipeDispatcher| (and thus a handle).
« no previous file with comments | « mojo/system/message_pipe.cc ('k') | mojo/system/proxy_message_pipe_endpoint.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698