Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2631)

Unified Diff: content/renderer/render_process_impl.cc

Issue 147973002: Move SetJavaScriptFlags() from webkit to content. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_process_impl.cc
diff --git a/content/renderer/render_process_impl.cc b/content/renderer/render_process_impl.cc
index 50a4b6e46ea3c25a31a466454062baa06b2921a0..8ab66c10d5241412e9d0446dd450052dd67ada68 100644
--- a/content/renderer/render_process_impl.cc
+++ b/content/renderer/render_process_impl.cc
@@ -30,7 +30,7 @@
#include "skia/ext/platform_canvas.h"
#include "third_party/WebKit/public/web/WebFrame.h"
#include "ui/surface/transport_dib.h"
-#include "webkit/glue/webkit_glue.h"
+#include "v8/include/v8.h"
#if defined(OS_MACOSX)
#include "base/mac/mac_util.h"
@@ -69,17 +69,21 @@ RenderProcessImpl::RenderProcessImpl()
#endif
// Out of process dev tools rely upon auto break behavior.
- webkit_glue::SetJavaScriptFlags("--debugger-auto-break");
+ static const char auto_break_flag[] = "--debugger-auto-break";
+ v8::V8::SetFlagsFromString(auto_break_flag, sizeof(auto_break_flag) - 1);
#if defined(OS_ANDROID)
- if (base::android::SysUtils::IsLowEndDevice())
- webkit_glue::SetJavaScriptFlags("--optimize-for-size");
+ if (base::android::SysUtils::IsLowEndDevice()) {
+ static const char optimize_flag[] = "--optimize-for-size";
+ v8::V8::SetFlagsFromString(optimize_flag, sizeof(optimize_flag) - 1);
+ }
#endif
const CommandLine& command_line = *CommandLine::ForCurrentProcess();
if (command_line.HasSwitch(switches::kJavaScriptFlags)) {
- webkit_glue::SetJavaScriptFlags(
- command_line.GetSwitchValueASCII(switches::kJavaScriptFlags));
+ v8::V8::SetFlagsFromString(
+ switches::kJavaScriptFlags,
+ static_cast<int>(strlen(switches::kJavaScriptFlags)));
}
// Turn on cross-site document blocking for renderer processes.

Powered by Google App Engine
This is Rietveld 408576698