Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: content/worker/worker_thread.cc

Issue 147973002: Move SetJavaScriptFlags() from webkit to content. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/worker/worker_thread.cc
diff --git a/content/worker/worker_thread.cc b/content/worker/worker_thread.cc
index 456457c4e780e6bb350d53946818d029557f7195..f40f2c91567cb37501abb3c9c2c45edfdb1b86f9 100644
--- a/content/worker/worker_thread.cc
+++ b/content/worker/worker_thread.cc
@@ -23,7 +23,7 @@
#include "third_party/WebKit/public/web/WebDatabase.h"
#include "third_party/WebKit/public/web/WebKit.h"
#include "third_party/WebKit/public/web/WebRuntimeFeatures.h"
-#include "webkit/glue/webkit_glue.h"
+#include "v8/include/v8.h"
using blink::WebRuntimeFeatures;
@@ -41,8 +41,9 @@ WorkerThread::WorkerThread() {
const CommandLine& command_line = *CommandLine::ForCurrentProcess();
if (command_line.HasSwitch(switches::kJavaScriptFlags)) {
- webkit_glue::SetJavaScriptFlags(
- command_line.GetSwitchValueASCII(switches::kJavaScriptFlags));
+ v8::V8::SetFlagsFromString(
+ switches::kJavaScriptFlags,
+ static_cast<int>(strlen(switches::kJavaScriptFlags)));
jam 2014/01/28 07:01:26 nit: just sizeof(switches::...)?
tfarina 2014/01/28 12:20:31 when I use sizeof here this happens: ../../conten
jam 2014/01/28 15:43:46 oops, sorry yeah that won't work when the constant
}
SetRuntimeFeaturesDefaultsAndUpdateFromArgs(command_line);

Powered by Google App Engine
This is Rietveld 408576698