Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1479543002: [proxies] Implement [[Delete]]. (Closed)

Created:
5 years ago by neis
Modified:
5 years ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com, Camillo Bruni, Jakob Kummerow
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] Implement [[Delete]]. LOG=N BUG=v8:1543 Committed: https://crrev.com/39efa4348aeaa1f1c316d5c8c9a87cdd0c591ef3 Cr-Commit-Position: refs/heads/master@{#32320}

Patch Set 1 #

Patch Set 2 : Fix typo #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+321 lines, -111 lines) Patch
M src/api.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/builtins.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/messages.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/objects.h View 4 chunks +11 lines, -10 lines 0 comments Download
M src/objects.cc View 8 chunks +82 lines, -60 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M test/cctest/test-elements-kind.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-heap.cc View 3 chunks +5 lines, -5 lines 0 comments Download
A test/mjsunit/harmony/proxies-delete-property.js View 1 chunk +190 lines, -0 lines 1 comment Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479543002/1
5 years ago (2015-11-25 14:17:02 UTC) #2
neis
PTAL.
5 years ago (2015-11-25 15:13:39 UTC) #5
rossberg
lgtm https://codereview.chromium.org/1479543002/diff/20001/test/mjsunit/harmony/proxies-delete-property.js File test/mjsunit/harmony/proxies-delete-property.js (right): https://codereview.chromium.org/1479543002/diff/20001/test/mjsunit/harmony/proxies-delete-property.js#newcode38 test/mjsunit/harmony/proxies-delete-property.js:38: // No trap. Nit: why not make that ...
5 years ago (2015-11-25 17:53:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479543002/20001
5 years ago (2015-11-26 08:39:53 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-26 09:34:14 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-26 09:34:36 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/39efa4348aeaa1f1c316d5c8c9a87cdd0c591ef3
Cr-Commit-Position: refs/heads/master@{#32320}

Powered by Google App Engine
This is Rietveld 408576698