src/bootstrapper.cc - Issue 1479543002: [proxies] Implement [[Delete]].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/bootstrapper.cc

Issue 1479543002: [proxies] Implement [[Delete]]. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix typo Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/bootstrapper.cc

diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc

index 20b3cfdf2096103ccc833bae1c91306798218ddb..1d1436dd87de4f2bd40dc8531a900c5d433e62e0 100644

--- a/src/bootstrapper.cc

+++ b/src/bootstrapper.cc

@@ -687,7 +687,9 @@ Handle<JSFunction> Genesis::GetThrowTypeErrorIntrinsic(

function->shared()->DontAdaptArguments();

// %ThrowTypeError% must not have a name property.

- JSReceiver::DeleteProperty(function, factory()->name_string()).Assert();

+ if (JSReceiver::DeleteProperty(function, factory()->name_string())

+ .IsNothing())

+ DCHECK(false);

// length needs to be non configurable.

Handle<Object> value(Smi::FromInt(function->shared()->length()), isolate());