Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1479503002: [turbofan] Require proper typing when inferring machine type from big-boy type. (Closed)

Created:
5 years ago by Jarin
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Require proper typing when inferring machine type from big-boy type. Committed: https://crrev.com/0e84cd470f286102d54042fc7e790e4a82146542 Cr-Commit-Position: refs/heads/master@{#32266}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/compiler/representation-change.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jarin
Could you take a look, please?
5 years ago (2015-11-25 10:17:39 UTC) #2
Benedikt Meurer
LGTM! more of that :-)
5 years ago (2015-11-25 11:23:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479503002/1
5 years ago (2015-11-25 11:48:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 11:49:33 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-25 11:49:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e84cd470f286102d54042fc7e790e4a82146542
Cr-Commit-Position: refs/heads/master@{#32266}

Powered by Google App Engine
This is Rietveld 408576698