Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: src/compiler/representation-change.cc

Issue 1479503002: [turbofan] Require proper typing when inferring machine type from big-boy type. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/representation-change.cc
diff --git a/src/compiler/representation-change.cc b/src/compiler/representation-change.cc
index b630f65245d0d304586ec7e65b09e4b1969e25d8..b4b408d7e032d4554dab7030ce6e7dbed5244011 100644
--- a/src/compiler/representation-change.cc
+++ b/src/compiler/representation-change.cc
@@ -471,8 +471,7 @@ const Operator* RepresentationChanger::Float64OperatorFor(
MachineType RepresentationChanger::TypeFromUpperBound(Type* type) {
- if (type->Is(Type::None()))
- return kTypeAny; // TODO(titzer): should be an error
+ CHECK(!type->Is(Type::None()));
if (type->Is(Type::Signed32())) return kTypeInt32;
if (type->Is(Type::Unsigned32())) return kTypeUint32;
if (type->Is(Type::Number())) return kTypeNumber;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698