Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 1479483003: [test] Make try-perf script more convenient to use. (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Make try-perf script more convenient to use. Warn if unknown benchmark configurations are triggered. NOTRY=true Committed: https://crrev.com/1e82da4b3077b03a2e75a371d28c5dfbc7f823ff Cr-Commit-Position: refs/heads/master@{#32274}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M tools/try_perf.py View 2 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Achenbach
PTAL
5 years ago (2015-11-25 13:40:25 UTC) #4
Benedikt Meurer
LGTM, nice!
5 years ago (2015-11-25 13:43:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479483003/1
5 years ago (2015-11-25 13:59:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 14:00:29 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-25 14:00:58 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e82da4b3077b03a2e75a371d28c5dfbc7f823ff
Cr-Commit-Position: refs/heads/master@{#32274}

Powered by Google App Engine
This is Rietveld 408576698