Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: tools/try_perf.py

Issue 1479483003: [test] Make try-perf script more convenient to use. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/try_perf.py
diff --git a/tools/try_perf.py b/tools/try_perf.py
index e07bf8cc278681e43881166faf20df58a52a2c46..2403f7d782ddf67f653f2fbb565308a73197a4a7 100755
--- a/tools/try_perf.py
+++ b/tools/try_perf.py
@@ -27,6 +27,25 @@ DEFAULT_BOTS = [
'v8_nexus10_perf_try',
]
+PUBLIC_BENCHMARKS = [
+ 'arewefastyet',
+ 'embenchen',
+ 'emscripten',
+ 'compile',
+ 'jetstream',
+ 'jsbench',
+ 'jstests',
+ 'kraken_orig',
+ 'massive',
+ 'memory',
+ 'octane',
+ 'octane-pr',
+ 'octane-tf',
+ 'octane-tf-pr',
+ 'simdjs',
+ 'sunspider',
+]
+
V8_BASE = os.path.abspath(os.path.dirname(os.path.dirname(__file__)))
def main():
@@ -47,6 +66,16 @@ def main():
print 'Please specify the benchmarks to run as arguments.'
return 1
+ for benchmark in options.benchmarks:
+ if benchmark not in PUBLIC_BENCHMARKS:
+ print ('%s not found in our benchmark list. The respective trybot might '
+ 'fail, unless you run something this script isn\'t aware of. '
+ 'Available public benchmarks: %s' % (benchmark, PUBLIC_BENCHMARKS))
+ print 'Proceed anyways? [Y/n] ',
+ answer = sys.stdin.readline().strip()
+ if answer != "" and answer != "Y" and answer != "y":
+ return 1
+
assert '"' not in options.extra_flags and '\'' not in options.extra_flags, (
'Invalid flag specification.')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698