base/memory/shared_memory_mac.cc - Issue 1479473002: base: Use std::move() instead of Pass() for real movable types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/shared_memory_mac.cc

Issue 1479473002: base: Use std::move() instead of Pass() for real movable types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: basepass: missing-include Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/memory/shared_memory_mac.cc

diff --git a/base/memory/shared_memory_mac.cc b/base/memory/shared_memory_mac.cc

index cdf0bc9fefa4eb60fd4333abdfd66c64b1009b89..a54d0bac73938458ad16136003f0737556cfb473 100644

--- a/base/memory/shared_memory_mac.cc

+++ b/base/memory/shared_memory_mac.cc

@@ -331,7 +331,7 @@ bool SharedMemory::Create(const SharedMemoryCreateOptions& options) {

}

requested_size_ = options.size;

- return PrepareMapFile(fp.Pass(), readonly_fd.Pass());

+ return PrepareMapFile(std::move(fp), std::move(readonly_fd));

}

bool SharedMemory::MapAt(off_t offset, size_t bytes) {

« no previous file with comments | « base/memory/scoped_ptr_unittest.cc ('k') | base/memory/shared_memory_mac_unittest.cc » ('j') | no next file with comments »