base/environment_unittest.cc - Issue 1479473002: base: Use std::move() instead of Pass() for real movable types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/environment_unittest.cc

Issue 1479473002: base: Use std::move() instead of Pass() for real movable types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: basepass: missing-include Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/environment_unittest.cc

diff --git a/base/environment_unittest.cc b/base/environment_unittest.cc

index f0577a8a82bbae73e9efb1cb33b66cd89448644e..c955e79b16c98637598027990d3188af4b692fe4 100644

--- a/base/environment_unittest.cc

+++ b/base/environment_unittest.cc

@@ -129,7 +129,7 @@ TEST_F(EnvironmentTest, AlterEnvironment) {

EnvironmentMap changes;

scoped_ptr<char*[]> e;

- e = AlterEnvironment(empty, changes).Pass();

+ e = AlterEnvironment(empty, changes);

EXPECT_TRUE(e[0] == NULL);

changes["A"] = "1";

« no previous file with comments | « base/environment.cc ('k') | base/feature_list_unittest.cc » ('j') | no next file with comments »