base/containers/scoped_ptr_hash_map.h - Issue 1479473002: base: Use std::move() instead of Pass() for real movable types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/containers/scoped_ptr_hash_map.h

Issue 1479473002: base: Use std::move() instead of Pass() for real movable types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: basepass: missing-include Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/containers/scoped_ptr_hash_map.h

diff --git a/base/containers/scoped_ptr_hash_map.h b/base/containers/scoped_ptr_hash_map.h

index 116070a095c0f64dff9b7b791533336dff992f48..bc635f47248e7273b58d7d111677bde4d78cb881 100644

--- a/base/containers/scoped_ptr_hash_map.h

+++ b/base/containers/scoped_ptr_hash_map.h

@@ -82,7 +82,7 @@ class ScopedPtrHashMap {

ScopedPtr ret(it->second);

it->second = NULL;

- return ret.Pass();

+ return ret;

}

ScopedPtr take(const Key& k) {

@@ -100,7 +100,7 @@ class ScopedPtrHashMap {

ScopedPtr ret(it->second);

data_.erase(it);

- return ret.Pass();

+ return ret;

}

ScopedPtr take_and_erase(const Key& k) {

« no previous file with comments | « no previous file | base/containers/scoped_ptr_map.h » ('j') | no next file with comments »