GN: Use all targets to determine whether a file is generated (for `check`).

GN: Use all targets to determine whether a file is generated (for `check`).

BUG=562675
Committed: https://crrev.com/b634f17a82d488df8851049c6ec2ad160b3547d3
Cr-Commit-Position: refs/heads/master@{#362135}

[jbroman, 2015-11-27 19:51:23]

jbroman@chromium.org changed reviewers:
+ brettw@chromium.org

[jbroman, 2015-11-27 19:51:23]

This is also not detected in HeaderChecker::CheckFile (see bug) because the gen
directory is stripped earlier.

This seems like the simplest fix. I'd include a test, but there don't seem to be
any existing tests of the logic in HeaderChecker::Run. I wrote one
(https://codereview.chromium.org/1476263005), but it also requires a somewhat
subtle change to TestWithScope, which I wasn't confident in.

[brettw, 2015-11-28 17:51:33]

lgtm

https://codereview.chromium.org/1479313002/diff/1/tools/gn/header_checker.cc
File tools/gn/header_checker.cc (right):

https://codereview.chromium.org/1479313002/diff/1/tools/gn/header_checker.cc#...
tools/gn/header_checker.cc:167: // the file map which includes all targets, not
just those being checked.
CAn you be explicit in the comment here that 'files' contains the files being
checked, while file_map_ contains all known files?

[jbroman, 2015-11-30 15:25:02]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2015-11-30 15:25:02]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1479313002/#ps20001
(title: "be more explicit, per brettw")

[jbroman, 2015-11-30 15:25:05]

https://codereview.chromium.org/1479313002/diff/1/tools/gn/header_checker.cc
File tools/gn/header_checker.cc (right):

https://codereview.chromium.org/1479313002/diff/1/tools/gn/header_checker.cc#...
tools/gn/header_checker.cc:167: // the file map which includes all targets, not
just those being checked.
On 2015/11/28 at 17:51:33, brettw wrote:
> CAn you be explicit in the comment here that 'files' contains the files being
checked, while file_map_ contains all known files?

Done.

[commit-bot: I haz the power, 2015-11-30 15:25:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1479313002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1479313002/20001

[commit-bot: I haz the power, 2015-11-30 15:42:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-30 15:43:41]

Description was changed from

==========
GN: Use all targets to determine whether a file is generated (for `check`).

BUG=562675
==========

to

==========
GN: Use all targets to determine whether a file is generated (for `check`).

BUG=562675

Committed: https://crrev.com/b634f17a82d488df8851049c6ec2ad160b3547d3
Cr-Commit-Position: refs/heads/master@{#362135}
==========

[commit-bot: I haz the power, 2015-11-30 15:43:41]

Patchset 2 (id:??) landed as
https://crrev.com/b634f17a82d488df8851049c6ec2ad160b3547d3
Cr-Commit-Position: refs/heads/master@{#362135}