Issue 1476263005: Test for generated files being detected during `gn check`.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1476263005: Test for generated files being detected during `gn check`. (Closed)

Created:
5 years ago by jbroman

Modified:
5 years ago

Reviewers:

Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-check-bug

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Test for generated files being detected during `gn check`. BUG=562675

Patch Set 1 #

Total comments: 1

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -2 lines)			Patch
	M	tools/gn/header_checker_unittest.cc	View		1 chunk	+28 lines, -0 lines	0 comments	Download
	M	tools/gn/test_with_scope.cc	View		1 chunk	+7 lines, -2 lines	1 comment	Download

Depends on Patchset:

Issue 1479313002 Patch 1

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

jbroman

5 years ago (2015-11-27 19:48:26 UTC) #1

https://codereview.chromium.org/1476263005/diff/1/tools/gn/test_with_scope.cc
File tools/gn/test_with_scope.cc (right):

https://codereview.chromium.org/1476263005/diff/1/tools/gn/test_with_scope.cc...
tools/gn/test_with_scope.cc:18: :
build_settings_(BuildSettingsWithBuildDir("//out/Debug/")),
This is somewhat subtle, but the Settings constructor copies the build dir out
of build_settings_ before SetBuildDir is called otherwise, leading to there not
being a generated output dir.

Expand Messages | Collapse Messages