Extract the SVG Filter Reference implementation out of the FilterEffectRenderer into its own type

Extract the SVG Filter Reference implementation out of the FilterEffectRenderer into its own type of filter.
This way we don't need to build a FilterEffectRenderer when rendering the SVG reference in the compositor.

(This is a copy of patch set 7 from issue 13984002.  I'd like to land it, but Rietveld won't let me modify someone else's issue, so I've uploaded separately.)

BUG=229714
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153537

[Stephen White, 2013-05-07 15:50:31]

Stephen, would you mind taking a look?  This is the same as Alex's last patch
from https://codereview.chromium.org/13984002/ which I LGTM'ed, updated to ToT.

[Stephen Chennney, 2013-05-08 18:09:05]

LGTM. I really need to learn more about how all this hangs together.

[Stephen White, 2013-06-20 20:23:53]

Note to self: this patch isn't going to work in its current form, since even the
accelerated filters rely on FilterOperations::outsets() to determine the
required source primitive size. And my patch to make that work for reference
filter operations requires the FilterEffects to be built by
FilterEffectRenderer.

One option would be to trigger a build of the FilterEffects (via a
ReferenceFilterBuilder) in FilterOperations::outsets() for the accelerated case,
if they're not already done.

[Stephen White, 2013-07-02 16:30:18]

Stephen, could you take another look?

It turns out there was a simple fix to the outsets issue: ReferenceFilterBuilder
wasn't setting its FilterResolution to a sane value, which was scaling all
filter params by zero. :)

Also updated past Alexis's colorspace conversion changes, and the associated
unit test.

[Stephen Chennney, 2013-07-02 22:10:29]

lgtm

[commit-bot: I haz the power, 2013-07-02 22:10:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/senorblanco@chromium.org/14793008/43001

[commit-bot: I haz the power, 2013-07-02 22:10:47]

Failed to apply patch for Source/core/rendering/FilterEffectRenderer.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/rendering/FilterEffectRenderer.cpp
  Hunk #3 FAILED at 105.
  Hunk #4 succeeded at 201 (offset 9 lines).
  Hunk #5 succeeded at 360 (offset 11 lines).
  Hunk #6 succeeded at 403 (offset 11 lines).
  1 out of 6 hunks FAILED -- saving rejects to file
Source/core/rendering/FilterEffectRenderer.cpp.rej

Patch:       Source/core/rendering/FilterEffectRenderer.cpp
Index: Source/core/rendering/FilterEffectRenderer.cpp
diff --git a/Source/core/rendering/FilterEffectRenderer.cpp
b/Source/core/rendering/FilterEffectRenderer.cpp
index
38a8fe0718913e6c20b6909dfd1a64902849d03d..2010d15da7b674e7153fd3176ebcf56d710248cd
100644
--- a/Source/core/rendering/FilterEffectRenderer.cpp
+++ b/Source/core/rendering/FilterEffectRenderer.cpp
@@ -28,24 +28,20 @@
 
 #include "core/rendering/FilterEffectRenderer.h"
 
-#include "SVGNames.h"
-#include "core/css/CSSPrimitiveValueMappings.h"
 #include "core/dom/Document.h"
-#include "core/loader/cache/CachedDocument.h"
-#include "core/loader/cache/CachedSVGDocumentReference.h"
-#include "core/platform/FloatConversion.h"
 #include "core/platform/graphics/ColorSpace.h"
 #include "core/platform/graphics/filters/FEColorMatrix.h"
 #include "core/platform/graphics/filters/FEComponentTransfer.h"
 #include "core/platform/graphics/filters/FEDropShadow.h"
 #include "core/platform/graphics/filters/FEGaussianBlur.h"
-#include "core/platform/graphics/filters/SourceAlpha.h"
 #include "core/platform/graphics/filters/custom/CustomFilterGlobalContext.h"
 #include "core/platform/graphics/filters/custom/CustomFilterValidatedProgram.h"
 #include "core/platform/graphics/filters/custom/FECustomFilter.h"
 #include
"core/platform/graphics/filters/custom/ValidatedCustomFilterOperation.h"
 #include "core/rendering/RenderLayer.h"
 #include "core/rendering/RenderView.h"
+#include "core/rendering/svg/ReferenceFilterBuilder.h"
+
 #include "core/svg/SVGElement.h"
 #include "core/svg/SVGFilterPrimitiveStandardAttributes.h"
 #include "wtf/MathExtras.h"
@@ -90,46 +86,6 @@ static PassRefPtr<FECustomFilter>
createCustomFilterEffect(Filter* filter, Docum
         operation->meshRows(), operation->meshColumns(), 
operation->meshType());
 }
 
-// Returns whether or not the SVGStyledElement object contains a valid
color-interpolation-filters attribute
-static bool getSVGStyledElementColorSpace(SVGStyledElement* svgStyledElement,
ColorSpace& cs)
-{
-    if (!svgStyledElement)
-        return false;
-
-    const RenderObject* renderer = svgStyledElement->renderer();
-    const RenderStyle* style = renderer ? renderer->style() : 0;
-    const SVGRenderStyle* svgStyle = style ? style->svgStyle() : 0;
-    EColorInterpolation eColorInterpolation = CI_AUTO;
-    if (svgStyle) {
-        // If a layout has been performed, then we can use the fast path to get
this attribute
-        eColorInterpolation = svgStyle->colorInterpolationFilters();
-    } else {
-        // Otherwise, use the slow path by using string comparison (used by
external svg files)
-        RefPtr<CSSValue> cssValue = svgStyledElement->getPresentationAttribute(
-            SVGNames::color_interpolation_filtersAttr.toString());
-        if (cssValue.get() && cssValue->isPrimitiveValue()) {
-            const CSSPrimitiveValue& primitiveValue =
*((CSSPrimitiveValue*)cssValue.get());
-            eColorInterpolation = (EColorInterpolation)primitiveValue;
-        } else {
-            return false;
-        }
-    }
-
-    switch (eColorInterpolation) {
-    case CI_AUTO:
-    case CI_SRGB:
-        cs = ColorSpaceDeviceRGB;
-        break;
-    case CI_LINEARRGB:
-        cs = ColorSpaceLinearRGB;
-        break;
-    default:
-        return false;
-    }
-
-    return true;
-}
-
 FilterEffectRenderer::FilterEffectRenderer()
     : Filter(AffineTransform())
     , m_graphicsBufferAttached(false)
@@ -149,86 +105,11 @@ GraphicsContext* FilterEffectRenderer::inputContext()
     return sourceImage() ? sourceImage()->context() : 0;
 }
 
-PassRefPtr<FilterEffect>
FilterEffectRenderer::buildReferenceFilter(RenderObject* renderer,
PassRefPtr<FilterEffect> previousEffect, ReferenceFilterOperation*
filterOperation)
-{
-    if (!renderer)
-        return 0;
-
-    Document* document = renderer->document();
-    ASSERT(document);
-
-    CachedSVGDocumentReference* cachedSVGDocumentReference =
filterOperation->cachedSVGDocumentReference();
-    CachedDocument* cachedSVGDocument = cachedSVGDocumentReference ?
cachedSVGDocumentReference->document() : 0;
-
-    // If we have an SVG document, this is an external reference. Otherwise
-    // we look up the referenced node in the current document.
-    if (cachedSVGDocument)
-        document = cachedSVGDocument->document();
-
-    if (!document)
-        return 0;
-
-    Element* filter = document->getElementById(filterOperation->fragment());
-    if (!filter) {
-        // Although we did not find the referenced filter, it might exist later
-        // in the document
-       
document->accessSVGExtensions()->addPendingResource(filterOperation->fragment(),
toElement(renderer->node()));
-        return 0;
-    }
-
-    if (!filter->isSVGElement() || !filter->hasTagName(SVGNames::filterTag))
-        return 0;
-
-    SVGFilterElement* filterElement = toSVGFilterElement(toSVGElement(filter));
-
-    RefPtr<FilterEffect> effect;
-
-    // FIXME: Figure out what to do with SourceAlpha. Right now, we're
-    // using the alpha of the original input layer, which is obviously
-    // wrong. We should probably be extracting the alpha from the 
-    // previousEffect, but this requires some more processing.  
-    // This may need a spec clarification.
-    RefPtr<SVGFilterBuilder> builder = SVGFilterBuilder::create(previousEffect,
SourceAlpha::create(this));
-
-    ColorSpace filterColorSpace = ColorSpaceDeviceRGB;
-    const bool useFilterColorSpace =
getSVGStyledElementColorSpace(filterElement, filterColorSpace);
-
-    for (Node* node = filterElement->firstChild(); node; node =
node->nextSibling()) {
-        if (!node->isSVGElement())
-            continue;
-
-        SVGElement* element = toSVGElement(node);
-        if (!element->isFilterEffect())
-            continue;
-
-        SVGFilterPrimitiveStandardAttributes* effectElement =
static_cast<SVGFilterPrimitiveStandardAttributes*>(element);
-
-        effect = effectElement->build(builder.get(), this);
-        if (!effect)
-            continue;
-
-        effectElement->setStandardAttributes(effect.get());
-       
effect->setEffectBoundaries(SVGLengthContext::resolveRectangle<SVGFilterPrimitiveStandardAttributes>(effectElement,
filterElement->primitiveUnits(), sourceImageRect()));
-
-        ColorSpace colorSpace = filterColorSpace;
-        if (useFilterColorSpace || getSVGStyledElementColorSpace(effectElement,
colorSpace))
-            effect->setOperatingColorSpace(colorSpace);
-        builder->add(effectElement->result(), effect);
-        m_effects.append(effect);
-    }
-    return effect;
-}
-
 bool FilterEffectRenderer::build(RenderObject* renderer, const
FilterOperations& operations)
 {
     m_hasCustomShaderFilter = false;
     m_hasFilterThatMovesPixels = operations.hasFilterThatMovesPixels();
     
-    // Keep the old effects on the stack until we've created the new effects.
-    // New FECustomFilters can reuse cached resources from old FECustomFilters.
-    FilterEffectList oldEffects;
-    m_effects.swap(oldEffects);
-
     RefPtr<FilterEffect> previousEffect = m_sourceGraphic;
     for (size_t i = 0; i < operations.operations().size(); ++i) {
         RefPtr<FilterEffect> effect;
@@ -236,8 +117,7 @@ bool FilterEffectRenderer::build(RenderObject* renderer,
const FilterOperations&
         switch (filterOperation->getOperationType()) {
         case FilterOperation::REFERENCE: {
             ReferenceFilterOperation* referenceOperation =
static_cast<ReferenceFilterOperation*>(filterOperation);
-            effect = buildReferenceFilter(renderer, previousEffect,
referenceOperation);
-            referenceOperation->setFilterEffect(effect, this);
+            effect = ReferenceFilterBuilder::build(this, renderer,
previousEffect.get(), referenceOperation);
             break;
         }
         case FilterOperation::GRAYSCALE: {
@@ -394,14 +274,17 @@ bool FilterEffectRenderer::build(RenderObject* renderer,
const FilterOperations&
                 effect->setClipsToBounds(false);
                 effect->setOperatingColorSpace(ColorSpaceDeviceRGB);
                 effect->inputEffects().append(previousEffect);
-                m_effects.append(effect);
             }
             previousEffect = effect.release();
         }
     }
 
+    // We need to keep the old effects alive until this point, so that filters
like FECustomFilter
+    // can share cached resources across frames.
+    m_lastEffect = previousEffect;
+
     // If we didn't make any effects, tell our caller we are not valid
-    if (!m_effects.size())
+    if (!m_lastEffect.get())
         return false;
 
     return true;
@@ -434,9 +317,8 @@ void FilterEffectRenderer::allocateBackingStoreIfNeeded()
 
 void FilterEffectRenderer::clearIntermediateResults()
 {
-    m_sourceGraphic->clearResult();
-    for (size_t i = 0; i < m_effects.size(); ++i)
-        m_effects[i]->clearResult();
+    if (m_lastEffect.get())
+        m_lastEffect->clearResultsRecursive();
 }
 
 void FilterEffectRenderer::apply()

[commit-bot: I haz the power, 2013-07-03 17:58:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/senorblanco@chromium.org/14793008/68002

[commit-bot: I haz the power, 2013-07-03 18:10:15]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[Stephen White, 2013-07-03 18:27:07]

+jamesr for WebKit/chromium/tests OWNERS

[dglazkov, 2013-07-03 21:45:20]

lgtm. me go quick!

[commit-bot: I haz the power, 2013-07-03 21:46:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/senorblanco@chromium.org/14793008/68002

[commit-bot: I haz the power, 2013-07-03 23:50:45]

Change committed as 153537