Source/core/platform/graphics/filters/FilterOperations.cpp - Issue 14793008: Extract the SVG Filter Reference implementation out of the FilterEffectRenderer into its own type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/platform/graphics/filters/FilterOperations.cpp

Issue 14793008: Extract the SVG Filter Reference implementation out of the FilterEffectRenderer into its own type (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix copyrights Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/platform/graphics/filters/FilterOperation.h ('k') | Source/core/platform/graphics/filters/ReferenceFilter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/platform/graphics/filters/FilterOperations.cpp

diff --git a/Source/core/platform/graphics/filters/FilterOperations.cpp b/Source/core/platform/graphics/filters/FilterOperations.cpp

index 870148231d4fc1197d8d4be0f5068f6336c7cb6a..6fd4491752f70566fe3c838625d011fc23790646 100644

--- a/Source/core/platform/graphics/filters/FilterOperations.cpp

+++ b/Source/core/platform/graphics/filters/FilterOperations.cpp

@@ -142,9 +142,9 @@ FilterOutsets FilterOperations::outsets() const

}

case FilterOperation::REFERENCE: {

ReferenceFilterOperation* referenceOperation = static_cast<ReferenceFilterOperation*>(filterOperation);

- if (referenceOperation->filterEffect()) {

+ if (referenceOperation->filter() && referenceOperation->filter()->lastEffect()) {

FloatRect outsetRect(0, 0, 1, 1);

- outsetRect = referenceOperation->filterEffect()->mapRectRecursive(outsetRect);

+ outsetRect = referenceOperation->filter()->lastEffect()->mapRectRecursive(outsetRect);

FilterOutsets outsets(

std::max(0.0f, -outsetRect.y()),

std::max(0.0f, outsetRect.x() + outsetRect.width() - 1),

« no previous file with comments | « Source/core/platform/graphics/filters/FilterOperation.h ('k') | Source/core/platform/graphics/filters/ReferenceFilter.h » ('j') | no next file with comments »