src/d8.h - Issue 14793004: deprecate Context::New which returns Persistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/d8.h

Issue 14793004: deprecate Context::New which returns Persistent (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: use Reset instead of operator= Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/d8.h

diff --git a/src/d8.h b/src/d8.h

index 77646c288070eac6d9e5e1b94937895239cb440a..c068dd9db1a0d6a31b97ee4cda008866ca9538b9 100644

--- a/src/d8.h

+++ b/src/d8.h

@@ -273,7 +273,7 @@ class Shell : public i::AllStatic {

static const char* ToCString(const v8::String::Utf8Value& value);

static void ReportException(Isolate* isolate, TryCatch* try_catch);

static Handle<String> ReadFile(Isolate* isolate, const char* name);

- static Persistent<Context> CreateEvaluationContext(Isolate* isolate);

+ static Local<Context> CreateEvaluationContext(Isolate* isolate);

static int RunMain(Isolate* isolate, int argc, char* argv[]);

static int Main(int argc, char* argv[]);

static void Exit(int exit_code);

« no previous file with comments | « samples/process.cc ('k') | src/d8.cc » ('j') | no next file with comments »