samples/process.cc - Issue 14793004: deprecate Context::New which returns Persistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/process.cc

Issue 14793004: deprecate Context::New which returns Persistent (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: use Reset instead of operator= Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: samples/process.cc

diff --git a/samples/process.cc b/samples/process.cc

index 75d6582e82b8c69aecb8a707ee40f6b75ccf18bb..fd3a82163904b376dc60a24a08298ff1c7a32a22 100644

--- a/samples/process.cc

+++ b/samples/process.cc

@@ -168,7 +168,7 @@ bool JsHttpRequestProcessor::Initialize(map<string, string>* opts,

// is what we need for the reference to remain after we return from

// this method. That persistent handle has to be disposed in the

// destructor.

- context_ = Context::New(NULL, global);

+ context_.Reset(GetIsolate(), Context::New(GetIsolate(), NULL, global));

// Enter the new context so all the following operations take place

// within it.

« no previous file with comments | « include/v8.h ('k') | src/d8.h » ('j') | no next file with comments »