Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1321)

Issue 1479063003: Drop [LegacyInterfaceTypeChecking] for EventTarget's dispatchEvent() (Closed)

Created:
5 years ago by philipj_slow
Modified:
5 years ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop [LegacyInterfaceTypeChecking] for EventTarget's dispatchEvent() This changes the exception for InvalidStateError to TypeError, which is per spec and what Gecko does. IE and Safari throw a generic Error. BUG=561338 Committed: https://crrev.com/57c5a84238b284bfcc9544de613daa869d1327ca Cr-Commit-Position: refs/heads/master@{#362153}

Patch Set 1 #

Patch Set 2 : fix test #

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479063003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479063003/20001
5 years ago (2015-11-27 13:19:18 UTC) #2
philipj_slow
Minor cleanup, PTAL.
5 years ago (2015-11-27 13:32:59 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-27 14:33:57 UTC) #6
Mike West
LGTM! Sorry I missed this on Friday. :/
5 years ago (2015-11-30 14:00:40 UTC) #7
philipj_slow
On 2015/11/30 14:00:40, Mike West wrote: > LGTM! Sorry I missed this on Friday. :/ ...
5 years ago (2015-11-30 16:19:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479063003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479063003/20001
5 years ago (2015-11-30 16:19:40 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-30 17:38:17 UTC) #11
commit-bot: I haz the power
5 years ago (2015-11-30 17:39:38 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/57c5a84238b284bfcc9544de613daa869d1327ca
Cr-Commit-Position: refs/heads/master@{#362153}

Powered by Google App Engine
This is Rietveld 408576698