third_party/WebKit/Source/core/events/EventTarget.cpp - Issue 1479063003: Drop [LegacyInterfaceTypeChecking] for EventTarget's dispatchEvent()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/EventTarget.cpp

Issue 1479063003: Drop [LegacyInterfaceTypeChecking] for EventTarget's dispatchEvent() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix test Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/Window/dispatchEvent-expected.txt ('k') | third_party/WebKit/Source/core/events/EventTarget.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/events/EventTarget.cpp

diff --git a/third_party/WebKit/Source/core/events/EventTarget.cpp b/third_party/WebKit/Source/core/events/EventTarget.cpp

index 8ced267d8478712e378c3ddde7b5b95981c2825a..5526aa5b7c33d68b1fbfbc7c2a215db053ee570a 100644

--- a/third_party/WebKit/Source/core/events/EventTarget.cpp

+++ b/third_party/WebKit/Source/core/events/EventTarget.cpp

@@ -249,10 +249,6 @@ bool EventTarget::clearAttributeEventListener(const AtomicString& eventType)

bool EventTarget::dispatchEventForBindings(PassRefPtrWillBeRawPtr<Event> event, ExceptionState& exceptionState)

{

- if (!event) {

- exceptionState.throwDOMException(InvalidStateError, "The event provided is null.");

- return false;

- }

if (event->type().isEmpty()) {

exceptionState.throwDOMException(InvalidStateError, "The event provided is uninitialized.");

return false;