Remove Simple Text Path

Remove Simple Text Path

Concluding a 3 year effort which unified the shaping logic across all
platforms, improved the performance of the complex text path through a
word cache, further improved the correctness of the complex text path
and removed all remaining dependencies on simple text path constructs
from SimpleFontData, SVG text and InlineTextBox, fixing tricky memory
regressions on Android we are now ready to remove the simple text code
path.

This means we now only have one code path for text processing removing a
class of bugs related to discrepancies between the code paths and get
rid of the legacy maintenance burden that was the simple text code
path. All our text processing now treats complex scripts as a first
class citizen and supports advanced typography at no additional cost.

BUG=561099
Committed: https://crrev.com/054a96857c077c00cb8b9c71e0a13a9051caa4f7
Cr-Commit-Position: refs/heads/master@{#427685}

[drott, 2015-11-26 13:27:25]

Description was changed from

==========
wip: remove simple path

BUG=
==========

to

==========
wip: remove simple path

BUG=
==========

[drott, 2015-11-26 13:38:18]

no default copy constructor needed

[drott, 2016-01-04 08:09:40]

Rebased on top of fmalita's font changes and other dependency fixes

[drott, 2016-01-04 09:06:51]

Description was changed from

==========
wip: remove simple path

BUG=
==========

to

==========
Remove Simple Text Path

Concluding a multi-year effort which improved the performance of
the complex text path through a word cache, unified the shaping
logic across all platforms, further improved the correctness of
the complex text path and removed all remaining dependencies on
simple text path constructs from SimpleFontData, SVG text and
InlineTextBox we are now ready to remove the simple text code
path.

This means we now only have one code path for text processing
removing a class of bugs related to discrepancies between the
code paths. All our text processing now supports advanced
typography, and complex scripts become a first class citizen.

BUG=561099
==========

[drott, 2016-01-04 09:06:51]

drott@chromium.org changed reviewers:
+ eae@chromium.org

[drott, 2016-01-04 09:09:34]

This is ready for review now, though it contains some redundancies and needs to
be rebased after 1552893002 and 1558683002 land.

[eae, 2016-01-04 18:03:45]

This is awesome but ideally we'd wait until the next branch point (late next
week) before we remove the simple text path entirely, just in case.

If you want to land the code that breaks the dependencies from complex text on
simple earlier though I'd be fine with that.

[drott, 2016-01-04 18:19:35]

On 2016/01/04 18:03:45, eae wrote:
> This is awesome but ideally we'd wait until the next branch point (late next
> week) before we remove the simple text path entirely, just in case.

Alright, I'll keep this one up-to-date and rebased, following the two CLs you're
going to land for SVG and code path selection. Then we can land it after the
branch point.

> If you want to land the code that breaks the dependencies from complex text on
> simple earlier though I'd be fine with that.

Ok. The remaining one that you could review if you have time is
https://codereview.chromium.org/1555013002/

[eae, 2016-01-04 18:20:30]

Thank you. I don't expect much to change in the platform or line-layout code
before the branch points other than the changes you already know about.

Thanks for being patient!

[drott, 2016-01-05 08:52:03]

Rebased on top of codepath choice removal, SVG text and emphasis mark fix

[drott, 2016-01-05 14:19:41]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-05 14:20:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1479003002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1479003002/80001

[commit-bot: I haz the power, 2016-01-05 15:50:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-05 15:50:38]

Dry run: This issue passed the CQ dry run.

[eae, 2016-01-05 16:22:19]

Awesome! 

LGTM but please wait until branch point as discussed.

[behdad, 2016-01-05 16:27:46]

behdad@chromium.org changed reviewers:
+ behdad@chromium.org

[behdad, 2016-01-05 16:27:46]

lgtm

Amazing!

[drott, 2016-01-08 13:45:39]

TODO: Remove TextPath.h and characterRangeCodePath functions in Character.h

[drott, 2016-01-21 13:54:32]

TODO, remove offset/endoffset from UTF16TextIterator

[drott, 2016-05-10 11:16:02]

TODO, remove TypeSettingFeatures

[drott, 2016-07-01 16:11:34]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[drott, 2016-07-01 16:11:43]

Rebased, UTF16Iterator offset removed, characterRangeCodePath, TextPath.h
removed

[commit-bot: I haz the power, 2016-07-01 16:11:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[drott, 2016-07-01 16:12:35]

$ git diff origin/master.. --stat
[...]
 30 files changed, 35 insertions(+), 2226 deletions(-)

;-)

[eae, 2016-07-01 16:14:33]

Awesome!

[commit-bot: I haz the power, 2016-07-01 16:15:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-01 16:15:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[drott, 2016-07-01 16:22:33]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[drott, 2016-07-01 16:22:36]

Rebased again

[commit-bot: I haz the power, 2016-07-01 16:22:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 16:26:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-01 16:26:10]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[drott, 2016-07-01 16:51:13]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-01 16:51:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 16:54:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-01 16:54:53]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[drott, 2016-07-04 07:57:49]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-04 07:58:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-04 08:01:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-04 08:01:28]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[drott, 2016-07-04 13:09:38]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-04 13:09:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-04 13:12:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-04 13:12:39]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[drott, 2016-07-04 13:41:41]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[drott, 2016-07-04 13:41:45]

Rebase

[commit-bot: I haz the power, 2016-07-04 13:41:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-04 13:45:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-04 13:45:37]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[drott, 2016-07-04 13:50:08]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-04 13:50:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-04 15:11:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-04 15:11:39]

Dry run: This issue passed the CQ dry run.

[drott, 2016-08-29 08:05:12]

Rebased

[drott, 2016-08-29 08:05:13]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 08:05:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 08:24:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 08:24:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[drott, 2016-08-29 08:34:06]

Fix CharacterTest

[drott, 2016-08-29 08:34:08]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 08:34:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 09:50:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 09:50:02]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[eae, 2016-09-20 08:07:13]

Nuke it from orbit, it's the only way to be sure.

[drott, 2016-09-21 08:08:31]

On 2016/09/20 at 08:07:13, eae wrote:
> Nuke it from orbit, it's the only way to be sure.

It certainly is, but do we want to wait until 54 on Android reaches stable?

[eae, 2016-09-21 09:08:06]

We do.

[drott, 2016-10-18 12:21:35]

Rebased

[drott, 2016-10-18 12:21:36]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 12:21:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[drott, 2016-10-18 12:24:54]

Description was changed from

==========
Remove Simple Text Path

Concluding a multi-year effort which improved the performance of
the complex text path through a word cache, unified the shaping
logic across all platforms, further improved the correctness of
the complex text path and removed all remaining dependencies on
simple text path constructs from SimpleFontData, SVG text and
InlineTextBox we are now ready to remove the simple text code
path.

This means we now only have one code path for text processing
removing a class of bugs related to discrepancies between the
code paths. All our text processing now supports advanced
typography, and complex scripts become a first class citizen.

BUG=561099
==========

to

==========
Remove Simple Text Path

Concluding a multi-year effort which improved the performance of the
complex text path through a word cache, unified the shaping logic across
all platforms, further improved the correctness of the complex text path
and removed all remaining dependencies on simple text path constructs
from SimpleFontData, SVG text and InlineTextBox, fixing tricky memory
regressions on Android we are now ready to remove the simple text code
path.

This means we now only have one code path for text processing removing a
class of bugs related to discrepancies between the code paths and get
rid of the legacy maintenance burden that was the simple text code
path. All our text processing now supports advanced typography, and
complex scripts become a first class citizen.

BUG=561099
==========

[commit-bot: I haz the power, 2016-10-18 14:09:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 14:09:04]

Dry run: This issue passed the CQ dry run.

[drott, 2016-10-25 14:29:36]

Description was changed from

==========
Remove Simple Text Path

Concluding a multi-year effort which improved the performance of the
complex text path through a word cache, unified the shaping logic across
all platforms, further improved the correctness of the complex text path
and removed all remaining dependencies on simple text path constructs
from SimpleFontData, SVG text and InlineTextBox, fixing tricky memory
regressions on Android we are now ready to remove the simple text code
path.

This means we now only have one code path for text processing removing a
class of bugs related to discrepancies between the code paths and get
rid of the legacy maintenance burden that was the simple text code
path. All our text processing now supports advanced typography, and
complex scripts become a first class citizen.

BUG=561099
==========

to

==========
Remove Simple Text Path

Concluding a 3 year effort which unified the shaping logic across all
platforms, improved the performance of the complex text path through a
word cache, further improved the correctness of the complex text path
and removed all remaining dependencies on simple text path constructs
from SimpleFontData, SVG text and InlineTextBox, fixing tricky memory
regressions on Android we are now ready to remove the simple text code
path.

This means we now only have one code path for text processing removing a
class of bugs related to discrepancies between the code paths and get
rid of the legacy maintenance burden that was the simple text code
path. All our text processing now supports advanced typography, and
complex scripts become a first class citizen.

BUG=561099
==========

[eae, 2016-10-25 17:51:05]

M54 has hit stable, might be time to rebase it again :)

[drott, 2016-10-26 01:18:24]

Rebased

[drott, 2016-10-26 01:23:53]

Description was changed from

==========
Remove Simple Text Path

Concluding a 3 year effort which unified the shaping logic across all
platforms, improved the performance of the complex text path through a
word cache, further improved the correctness of the complex text path
and removed all remaining dependencies on simple text path constructs
from SimpleFontData, SVG text and InlineTextBox, fixing tricky memory
regressions on Android we are now ready to remove the simple text code
path.

This means we now only have one code path for text processing removing a
class of bugs related to discrepancies between the code paths and get
rid of the legacy maintenance burden that was the simple text code
path. All our text processing now supports advanced typography, and
complex scripts become a first class citizen.

BUG=561099
==========

to

==========
Remove Simple Text Path

Concluding a 3 year effort which unified the shaping logic across all
platforms, improved the performance of the complex text path through a
word cache, further improved the correctness of the complex text path
and removed all remaining dependencies on simple text path constructs
from SimpleFontData, SVG text and InlineTextBox, fixing tricky memory
regressions on Android we are now ready to remove the simple text code
path.

This means we now only have one code path for text processing removing a
class of bugs related to discrepancies between the code paths and get
rid of the legacy maintenance burden that was the simple text code
path. All our text processing now treats complex scripts as a first
class citizen and supports advanced typography at no additional cost.

BUG=561099
==========

[drott, 2016-10-26 01:24:11]

The CQ bit was checked by drott@chromium.org

[drott, 2016-10-26 01:24:12]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org,
behdad@chromium.org
Link to the patchset: https://codereview.chromium.org/1479003002/#ps240001
(title: "Rebased")

[commit-bot: I haz the power, 2016-10-26 01:24:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2016-10-26 01:28:22]

On 2016/10/26 01:24:37, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

\o/

[commit-bot: I haz the power, 2016-10-26 01:33:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 01:34:00]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[drott, 2016-10-26 12:29:42]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 12:29:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[drott, 2016-10-26 13:58:50]

drott@chromium.org changed reviewers:
+ bokan@chromium.org, dcheng@chromium.org, pdr@chromium.org

[commit-bot: I haz the power, 2016-10-26 13:59:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 13:59:17]

Dry run: This issue passed the CQ dry run.

[drott, 2016-10-26 13:59:54]

drott@chromium.org changed reviewers:
+ jochen@chromium.org

[drott, 2016-10-26 14:00:55]

bokan@, dcheng@, eae@, jochen@, pdr@ - could you please review
third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp to unblock landing this?
Thank you!

[bokan, 2016-10-26 14:12:00]

FrameLoaderClientImpl lgtm

[drott, 2016-10-26 14:17:19]

The CQ bit was checked by drott@chromium.org

[drott, 2016-10-26 14:17:33]

On 2016/10/26 at 14:12:00, bokan wrote:
> FrameLoaderClientImpl lgtm

Thanks for the quick review.

[commit-bot: I haz the power, 2016-10-26 14:17:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 14:23:09]

Committed patchset #13 (id:240001)

[commit-bot: I haz the power, 2016-10-26 14:25:55]

Description was changed from

==========
Remove Simple Text Path

Concluding a 3 year effort which unified the shaping logic across all
platforms, improved the performance of the complex text path through a
word cache, further improved the correctness of the complex text path
and removed all remaining dependencies on simple text path constructs
from SimpleFontData, SVG text and InlineTextBox, fixing tricky memory
regressions on Android we are now ready to remove the simple text code
path.

This means we now only have one code path for text processing removing a
class of bugs related to discrepancies between the code paths and get
rid of the legacy maintenance burden that was the simple text code
path. All our text processing now treats complex scripts as a first
class citizen and supports advanced typography at no additional cost.

BUG=561099
==========

to

==========
Remove Simple Text Path

Concluding a 3 year effort which unified the shaping logic across all
platforms, improved the performance of the complex text path through a
word cache, further improved the correctness of the complex text path
and removed all remaining dependencies on simple text path constructs
from SimpleFontData, SVG text and InlineTextBox, fixing tricky memory
regressions on Android we are now ready to remove the simple text code
path.

This means we now only have one code path for text processing removing a
class of bugs related to discrepancies between the code paths and get
rid of the legacy maintenance burden that was the simple text code
path. All our text processing now treats complex scripts as a first
class citizen and supports advanced typography at no additional cost.

BUG=561099

Committed: https://crrev.com/054a96857c077c00cb8b9c71e0a13a9051caa4f7
Cr-Commit-Position: refs/heads/master@{#427685}
==========

[commit-bot: I haz the power, 2016-10-26 14:25:57]

Patchset 13 (id:??) landed as
https://crrev.com/054a96857c077c00cb8b9c71e0a13a9051caa4f7
Cr-Commit-Position: refs/heads/master@{#427685}