Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Unified Diff: src/objects-inl.h

Issue 1478943003: Use WeakCells in the optimized code map rather than traversing in pause. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Patch One. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/objects.cc ('K') | « src/objects.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index 597a00cd6c084b6e0c7ddc066a1fef7796671108..7974cf64abac7c34b421e83eb80217dca760d3aa 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -2036,7 +2036,7 @@ Object* WeakCell::value() const { return READ_FIELD(this, kValueOffset); }
void WeakCell::clear() {
- DCHECK(GetHeap()->gc_state() == Heap::MARK_COMPACT);
+ DCHECK(GetHeap()->gc_state() == Heap::MARK_COMPACT || value()->IsUndefined());
Michael Starzinger 2015/11/27 10:06:40 I assume this exception is just here because of th
mvstanton 2015/12/01 11:28:15 Good idea, done.
WRITE_FIELD(this, kValueOffset, Smi::FromInt(0));
}
« src/objects.cc ('K') | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698