Use WeakCells in the optimized code map rather than traversing in pause.

src/objects-inl.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Review notes:
 //
 // - The use of macros in these inline functions may seem superfluous
 // but it is absolutely needed to make sure gcc generates optimal
 // code. gcc is not happy when attempting to inline too deep.
 //
@@ skipping 2018 matching lines @@
 
 void PropertyCell::set_property_details(PropertyDetails details) {
   set_property_details_raw(details.AsSmi());
 }
 
 
 Object* WeakCell::value() const { return READ_FIELD(this, kValueOffset); }
 
 
 void WeakCell::clear() {
-  DCHECK(GetHeap()->gc_state() == Heap::MARK_COMPACT);
+  DCHECK(GetHeap()->gc_state() == Heap::MARK_COMPACT || value()->IsUndefined());

[Michael Starzinger, 2015/11/27 10:06:40]

I assume this exception is just here because of the call to "clear" in
Heap::CreateInitialObjects. Correct? Could we instead check "this ==
GetHeap()->empty_weak_cell()" to make that clearer and keep the filter of what
is allowed narrow?

[mvstanton, 2015/12/01 11:28:15]

Good idea, done.

   WRITE_FIELD(this, kValueOffset, Smi::FromInt(0));
 }
 
 
 void WeakCell::initialize(HeapObject* val) {
   WRITE_FIELD(this, kValueOffset, val);
   Heap* heap = GetHeap();
   // We just have to execute the generational barrier here because we never
   // mark through a weak cell and collect evacuation candidates when we process
   // all weak cells.
@@ skipping 5841 matching lines @@
 #undef WRITE_INT64_FIELD
 #undef READ_BYTE_FIELD
 #undef WRITE_BYTE_FIELD
 #undef NOBARRIER_READ_BYTE_FIELD
 #undef NOBARRIER_WRITE_BYTE_FIELD
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_OBJECTS_INL_H_