build/common.gypi - Issue 14789003: mac: Reenable clang plugin on asan bot now that it's using the same clang as the other bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 14789003: mac: Reenable clang plugin on asan bot now that it's using the same clang as the other bots. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index fe4ecbc0edbf08fe8e7bb628300a5bd9b281fb3b..cca6f751ee1c9ba5567f0c328d12729689934269 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -3720,10 +3720,7 @@

'$(inherited)', '-std=gnu++11',

}],

- # TODO(thakis): Reenable plugins with once

- # tools/clang/scripts/update.sh no longer pins clang to an ancient

- # version for asan (http://crbug.com/170629)

- ['clang==1 and clang_use_chrome_plugins==1 and asan!=1', {

+ ['clang==1 and clang_use_chrome_plugins==1', {

'OTHER_CFLAGS': [

'<@(clang_chrome_plugins_flags)',

« no previous file with comments | « no previous file | no next file » | no next file with comments »