Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3978)

Unified Diff: chrome/browser/engagement/site_engagement_helper_unittest.cc

Issue 1478643002: Refactor media out of WebContentsImpl to MediaWebContentsObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix namespace for cast. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/engagement/site_engagement_helper.cc ('k') | chromecast/browser/cast_content_window.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/engagement/site_engagement_helper_unittest.cc
diff --git a/chrome/browser/engagement/site_engagement_helper_unittest.cc b/chrome/browser/engagement/site_engagement_helper_unittest.cc
index 6b8fee78c17ab0e2c63965077b613b2d9f7fe0e0..edcbdb2bbabe8f50570712ed6a34fea68790a313 100644
--- a/chrome/browser/engagement/site_engagement_helper_unittest.cc
+++ b/chrome/browser/engagement/site_engagement_helper_unittest.cc
@@ -53,11 +53,13 @@ class SiteEngagementHelperTest : public BrowserWithTestWindowTest {
}
void MediaStartedPlaying(SiteEngagementHelper* helper) {
- helper->media_tracker_.MediaStartedPlaying();
+ helper->media_tracker_.MediaStartedPlaying(
+ content::WebContentsObserver::MediaPlayerId(nullptr, 1));
}
- void MediaPaused(SiteEngagementHelper* helper) {
- helper->media_tracker_.MediaPaused();
+ void MediaStoppedPlaying(SiteEngagementHelper* helper) {
+ helper->media_tracker_.MediaStoppedPlaying(
+ content::WebContentsObserver::MediaPlayerId(nullptr, 1));
}
// Set a pause timer on the input tracker for test purposes.
@@ -235,7 +237,7 @@ TEST_F(SiteEngagementHelperTest, MediaEngagement) {
EXPECT_EQ(0, service->GetScore(url2));
EXPECT_TRUE(media_tracker_timer->IsRunning());
- MediaPaused(helper.get());
+ MediaStoppedPlaying(helper.get());
media_tracker_timer->Fire();
EXPECT_DOUBLE_EQ(0.53, service->GetScore(url1));
EXPECT_EQ(0, service->GetScore(url2));
@@ -270,7 +272,7 @@ TEST_F(SiteEngagementHelperTest, MediaEngagement) {
EXPECT_EQ(0.53, service->GetScore(url2));
EXPECT_TRUE(media_tracker_timer->IsRunning());
- MediaPaused(helper.get());
+ MediaStoppedPlaying(helper.get());
web_contents->WasShown();
media_tracker_timer->Fire();
EXPECT_DOUBLE_EQ(0.55, service->GetScore(url1));
« no previous file with comments | « chrome/browser/engagement/site_engagement_helper.cc ('k') | chromecast/browser/cast_content_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698