Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5603)

Unified Diff: chrome/browser/engagement/site_engagement_helper.cc

Issue 1478643002: Refactor media out of WebContentsImpl to MediaWebContentsObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix namespace for cast. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/site_engagement_helper.cc
diff --git a/chrome/browser/engagement/site_engagement_helper.cc b/chrome/browser/engagement/site_engagement_helper.cc
index 81ffdf4766048510b6dca35de4d764991e096546..ada901b5351263117bf0e2753e478230b0a264c9 100644
--- a/chrome/browser/engagement/site_engagement_helper.cc
+++ b/chrome/browser/engagement/site_engagement_helper.cc
@@ -111,26 +111,32 @@ void SiteEngagementHelper::InputTracker::DidGetUserInteraction(
SiteEngagementHelper::MediaTracker::MediaTracker(
SiteEngagementHelper* helper,
content::WebContents* web_contents)
- : PeriodicTracker(helper), content::WebContentsObserver(web_contents),
- is_hidden_(false),
- is_playing_(false) {}
+ : PeriodicTracker(helper),
+ content::WebContentsObserver(web_contents),
+ is_hidden_(false) {}
+
+SiteEngagementHelper::MediaTracker::~MediaTracker() {}
void SiteEngagementHelper::MediaTracker::TrackingStarted() {
- if (is_playing_)
+ if (!active_media_players_.empty())
helper()->RecordMediaPlaying(is_hidden_);
Pause();
}
-void SiteEngagementHelper::MediaTracker::MediaStartedPlaying() {
+void SiteEngagementHelper::MediaTracker::MediaStartedPlaying(
+ const MediaPlayerId& id) {
// Only begin engagement detection when media actually starts playing.
- is_playing_ = true;
+ active_media_players_.push_back(id);
if (!IsTimerRunning())
Start(base::TimeDelta::FromSeconds(g_seconds_delay_after_media_starts));
}
-void SiteEngagementHelper::MediaTracker::MediaPaused() {
- is_playing_ = false;
+void SiteEngagementHelper::MediaTracker::MediaStoppedPlaying(
+ const MediaPlayerId& id) {
+ active_media_players_.erase(std::remove(active_media_players_.begin(),
+ active_media_players_.end(), id),
+ active_media_players_.end());
}
void SiteEngagementHelper::MediaTracker::WasShown() {
« no previous file with comments | « chrome/browser/engagement/site_engagement_helper.h ('k') | chrome/browser/engagement/site_engagement_helper_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698